diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-04-12 07:35:13 +0200 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-04-14 13:22:31 +0200 |
| commit | bd0a690632268789a9c5611e90ea5255265e7cac (patch) | |
| tree | 645590478e8a42b38c4849d28c995ebcdd1adbaa /test/addons/dlopen-ping-pong | |
| parent | a486736af8d451b9bde58e6d1bf0e00cae3f2c87 (diff) | |
| download | android-node-v8-bd0a690632268789a9c5611e90ea5255265e7cac.tar.gz android-node-v8-bd0a690632268789a9c5611e90ea5255265e7cac.tar.bz2 android-node-v8-bd0a690632268789a9c5611e90ea5255265e7cac.zip | |
test: fix warning in dlopen-ping-pong/binding.cc
Currently, the following compiler warning is issued:
../binding.cc:26:27:
warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
const String::Utf8Value filename(args[0]);
^
This commit updates the code to use the Isolate version.
PR-URL: https://github.com/nodejs/node/pull/19966
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/addons/dlopen-ping-pong')
| -rw-r--r-- | test/addons/dlopen-ping-pong/binding.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/addons/dlopen-ping-pong/binding.cc b/test/addons/dlopen-ping-pong/binding.cc index b35db4e708..a3b9af1b80 100644 --- a/test/addons/dlopen-ping-pong/binding.cc +++ b/test/addons/dlopen-ping-pong/binding.cc @@ -23,7 +23,7 @@ typedef const char* (*ping)(void); static ping ping_func; void LoadLibrary(const FunctionCallbackInfo<Value>& args) { - const String::Utf8Value filename(args[0]); + const String::Utf8Value filename(args.GetIsolate(), args[0]); void* handle = dlopen(*filename, RTLD_LAZY); assert(handle != nullptr); ping_func = reinterpret_cast<ping>(dlsym(handle, "dlopen_ping")); |