diff options
author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-03-09 08:29:27 +0100 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-03-11 16:13:39 +0100 |
commit | 695590e386845bc11bb42aa7f26327f2fba6d2a5 (patch) | |
tree | 2f4dcf6b171bd565c9cc048c22ae01e4ae8b08ad /test/addons/callback-scope | |
parent | a7e298a4a2720de6d463fb143b51f320136eab42 (diff) | |
download | android-node-v8-695590e386845bc11bb42aa7f26327f2fba6d2a5.tar.gz android-node-v8-695590e386845bc11bb42aa7f26327f2fba6d2a5.tar.bz2 android-node-v8-695590e386845bc11bb42aa7f26327f2fba6d2a5.zip |
test: fix compiler warnings in callback-scope
Currently there are two compiler warnings generated from the addons test
callback-scope:
../binding.cc:44:10:
warning: 'Resolve' is deprecated [-Wdeprecated-declarations]
local->Resolve(v8::Undefined(isolate));
^
../../../../deps/v8/include/v8.h:3893:45:
note: 'Resolve' has been explicitly marked deprecated here
V8_DEPRECATED("Use maybe version", void Resolve(Local<Value> value));
^
../binding.cc:52:54:
warning: 'New' is deprecated [-Wdeprecated-declarations]
persistent.Reset(isolate, v8::Promise::Resolver::New(isolate));
^
../../../../deps/v8/include/v8.h:3880:42:
note: 'New' has been explicitly marked deprecated here
Local<Resolver> New(Isolate* isolate));
This commit updates the test to use non-deprecated functions.
PR-URL: https://github.com/nodejs/node/pull/19252
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'test/addons/callback-scope')
-rw-r--r-- | test/addons/callback-scope/binding.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/test/addons/callback-scope/binding.cc b/test/addons/callback-scope/binding.cc index 3b69d2d572..94d5ec91d7 100644 --- a/test/addons/callback-scope/binding.cc +++ b/test/addons/callback-scope/binding.cc @@ -41,7 +41,8 @@ static void Callback(uv_work_t* req, int ignored) { v8::Local<v8::Promise::Resolver> local = v8::Local<v8::Promise::Resolver>::New(isolate, persistent); - local->Resolve(v8::Undefined(isolate)); + local->Resolve(isolate->GetCurrentContext(), + v8::Undefined(isolate)).ToChecked(); delete req; } @@ -49,7 +50,8 @@ static void TestResolveAsync(const v8::FunctionCallbackInfo<v8::Value>& args) { v8::Isolate* isolate = args.GetIsolate(); if (persistent.IsEmpty()) { - persistent.Reset(isolate, v8::Promise::Resolver::New(isolate)); + persistent.Reset(isolate, v8::Promise::Resolver::New( + isolate->GetCurrentContext()).ToLocalChecked()); uv_work_t* req = new uv_work_t; |