diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2018-01-20 01:00:34 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-01-21 02:19:46 +0100 |
| commit | d9b59def72c718aaad3eefb6bf43f409ccefe4d2 (patch) | |
| tree | ec02442a3153500b91e368c873db4d1a3763e567 /test/addons-napi/test_fatal/test.js | |
| parent | c6682636be4955e2181c00e7d4868fbf6682a5c5 (diff) | |
| download | android-node-v8-d9b59def72c718aaad3eefb6bf43f409ccefe4d2.tar.gz android-node-v8-d9b59def72c718aaad3eefb6bf43f409ccefe4d2.tar.bz2 android-node-v8-d9b59def72c718aaad3eefb6bf43f409ccefe4d2.zip | |
build,test: make building addon tests less fragile
* Get rid of recursive `make` when building the node binary. An earlier
commit makes GYP write out rules that we can use for proper dependency
tracking.
* Use module name 'binding' in addons.md and addons-napi/*/binding.gyp.
This massively simplifies the logic for generating the build rules.
* Check in auto-generated add-on tests from `doc/api/addons.md`. The
files change rarely and generating them dynamically causes no end of
race conditions and special-casing during the build.
PR-URL: https://github.com/nodejs/node/pull/17407
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Diffstat (limited to 'test/addons-napi/test_fatal/test.js')
| -rw-r--r-- | test/addons-napi/test_fatal/test.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/addons-napi/test_fatal/test.js b/test/addons-napi/test_fatal/test.js index 7ff9a39563..c8724d054b 100644 --- a/test/addons-napi/test_fatal/test.js +++ b/test/addons-napi/test_fatal/test.js @@ -2,7 +2,7 @@ const common = require('../../common'); const assert = require('assert'); const child_process = require('child_process'); -const test_fatal = require(`./build/${common.buildType}/test_fatal`); +const test_fatal = require(`./build/${common.buildType}/binding`); // Test in a child process because the test code will trigger a fatal error // that crashes the process. |