diff options
author | Ben Noordhuis <info@bnoordhuis.nl> | 2016-06-19 10:14:24 +0200 |
---|---|---|
committer | Ben Noordhuis <info@bnoordhuis.nl> | 2016-06-29 13:49:31 +0200 |
commit | 0672fca921e3ace9f10309c58ead71fa31750e39 (patch) | |
tree | 7975966a83b2a6fe28857ffa659c2e8b754abf8b /test/abort/test-abort-uncaught-exception.js | |
parent | 5251fe52c337515235e72343e93788aecf148bc4 (diff) | |
download | android-node-v8-0672fca921e3ace9f10309c58ead71fa31750e39.tar.gz android-node-v8-0672fca921e3ace9f10309c58ead71fa31750e39.tar.bz2 android-node-v8-0672fca921e3ace9f10309c58ead71fa31750e39.zip |
test: fix abort/test-abort-uncaught-exception
The --abort-on-uncaught-exception can terminate the process with either
a SIGABRT or a SIGILL signal but the test only expected SIGABRT.
PR-URL: https://github.com/nodejs/node/pull/6734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/abort/test-abort-uncaught-exception.js')
-rw-r--r-- | test/abort/test-abort-uncaught-exception.js | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/test/abort/test-abort-uncaught-exception.js b/test/abort/test-abort-uncaught-exception.js index 0d9fa6884d..f984719376 100644 --- a/test/abort/test-abort-uncaught-exception.js +++ b/test/abort/test-abort-uncaught-exception.js @@ -9,23 +9,26 @@ if (process.argv[2] === 'child') { throw new Error('child error'); } else { run('', null); - run('--abort-on-uncaught-exception', 'SIGABRT'); + run('--abort-on-uncaught-exception', ['SIGABRT', 'SIGILL']); } -function run(flags, signal) { +function run(flags, signals) { const args = [__filename, 'child']; if (flags) args.unshift(flags); const child = spawn(node, args); child.on('exit', common.mustCall(function(code, sig) { - if (!common.isWindows) { - assert.strictEqual(sig, signal); - } else { - if (signal) + if (common.isWindows) { + if (signals) assert.strictEqual(code, 3); else assert.strictEqual(code, 1); + } else { + if (signals) + assert.strictEqual(signals.includes(sig), true); + else + assert.strictEqual(sig, null); } })); } |