diff options
author | gengjiawen <technicalcute@gmail.com> | 2019-03-10 17:23:56 +0800 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-03-21 07:23:44 +0100 |
commit | f091d4e840fa5208bcab0c1f98743a667a995094 (patch) | |
tree | 0acd16389d0e51fb8403672d2eca0c561030f48d /src | |
parent | f47adfbda5c06263a78c0c74a705b0d5d3cd2944 (diff) | |
download | android-node-v8-f091d4e840fa5208bcab0c1f98743a667a995094.tar.gz android-node-v8-f091d4e840fa5208bcab0c1f98743a667a995094.tar.bz2 android-node-v8-f091d4e840fa5208bcab0c1f98743a667a995094.zip |
src: apply clang-tidy rule modernize-use-emplace
PR-URL: https://github.com/nodejs/node/pull/26564
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'src')
-rw-r--r-- | src/inspector_socket.cc | 9 | ||||
-rw-r--r-- | src/node_file.cc | 4 | ||||
-rw-r--r-- | src/node_messaging.cc | 5 | ||||
-rw-r--r-- | src/node_native_module.cc | 2 | ||||
-rw-r--r-- | src/node_process_methods.cc | 4 | ||||
-rw-r--r-- | src/node_url.cc | 2 |
6 files changed, 13 insertions, 13 deletions
diff --git a/src/inspector_socket.cc b/src/inspector_socket.cc index 7fd691ddd8..161e93c0af 100644 --- a/src/inspector_socket.cc +++ b/src/inspector_socket.cc @@ -554,10 +554,11 @@ class HttpHandler : public ProtocolHandler { static int OnMessageComplete(parser_t* parser) { // Event needs to be fired after the parser is done. HttpHandler* handler = From(parser); - handler->events_.push_back( - HttpEvent(handler->path_, parser->upgrade, parser->method == HTTP_GET, - handler->HeaderValue("Sec-WebSocket-Key"), - handler->HeaderValue("Host"))); + handler->events_.emplace_back(handler->path_, + parser->upgrade, + parser->method == HTTP_GET, + handler->HeaderValue("Sec-WebSocket-Key"), + handler->HeaderValue("Host")); handler->path_ = ""; handler->parsing_value_ = false; handler->headers_.clear(); diff --git a/src/node_file.cc b/src/node_file.cc index 95a239ee52..063293e788 100644 --- a/src/node_file.cc +++ b/src/node_file.cc @@ -661,7 +661,7 @@ void AfterScanDirWithTypes(uv_fs_t* req) { return req_wrap->Reject(error); name_v.push_back(filename.ToLocalChecked()); - type_v.push_back(Integer::New(isolate, ent.type)); + type_v.emplace_back(Integer::New(isolate, ent.type)); } Local<Array> result = Array::New(isolate, 2); @@ -1508,7 +1508,7 @@ static void ReadDir(const FunctionCallbackInfo<Value>& args) { name_v.push_back(filename.ToLocalChecked()); if (with_types) { - type_v.push_back(Integer::New(isolate, ent.type)); + type_v.emplace_back(Integer::New(isolate, ent.type)); } } diff --git a/src/node_messaging.cc b/src/node_messaging.cc index a76c64d743..7fcbde67e0 100644 --- a/src/node_messaging.cc +++ b/src/node_messaging.cc @@ -387,9 +387,8 @@ Maybe<bool> Message::Serialize(Environment* env, env->isolate_data()->node_allocator()->UnregisterPointer( contents.Data(), contents.ByteLength()); - array_buffer_contents_.push_back( - MallocedBuffer<char> { static_cast<char*>(contents.Data()), - contents.ByteLength() }); + array_buffer_contents_.emplace_back(MallocedBuffer<char>{ + static_cast<char*>(contents.Data()), contents.ByteLength()}); } delegate.Finish(); diff --git a/src/node_native_module.cc b/src/node_native_module.cc index 33df8c0aa8..41f1588c4d 100644 --- a/src/node_native_module.cc +++ b/src/node_native_module.cc @@ -92,7 +92,7 @@ void NativeModuleLoader::ModuleIdsGetter( ids.reserve(source_.size()); for (auto const& x : source_) { - ids.push_back(OneByteString(isolate, x.first.c_str(), x.first.size())); + ids.emplace_back(OneByteString(isolate, x.first.c_str(), x.first.size())); } info.GetReturnValue().Set(Array::New(isolate, ids.data(), ids.size())); diff --git a/src/node_process_methods.cc b/src/node_process_methods.cc index 3cf2670a88..d2ba00b89b 100644 --- a/src/node_process_methods.cc +++ b/src/node_process_methods.cc @@ -255,7 +255,7 @@ static void GetActiveRequests(const FunctionCallbackInfo<Value>& args) { AsyncWrap* w = req_wrap->GetAsyncWrap(); if (w->persistent().IsEmpty()) continue; - request_v.push_back(w->GetOwner()); + request_v.emplace_back(w->GetOwner()); } args.GetReturnValue().Set( @@ -271,7 +271,7 @@ void GetActiveHandles(const FunctionCallbackInfo<Value>& args) { for (auto w : *env->handle_wrap_queue()) { if (!HandleWrap::HasRef(w)) continue; - handle_v.push_back(w->GetOwner()); + handle_v.emplace_back(w->GetOwner()); } args.GetReturnValue().Set( Array::New(env->isolate(), handle_v.data(), handle_v.size())); diff --git a/src/node_url.cc b/src/node_url.cc index 5e241b76f1..e5e9eff74c 100644 --- a/src/node_url.cc +++ b/src/node_url.cc @@ -2053,7 +2053,7 @@ void URL::Parse(const char* input, break; default: if (url->path.size() == 0) - url->path.push_back(""); + url->path.emplace_back(""); if (url->path.size() > 0 && ch != kEOL) AppendOrEscape(&url->path[0], ch, C0_CONTROL_ENCODE_SET); } |