diff options
| author | cjihrig <cjihrig@gmail.com> | 2019-11-20 14:26:38 -0500 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-11-22 21:41:10 +0100 |
| commit | e4812d62ebc7830d20872da44cfa4539d7ff0125 (patch) | |
| tree | 3d3409b44ef43160174d6ad9e9c91bb5c731a407 /src | |
| parent | 0d285276f8028fdeb2c16ad47e09e9cd022f3a90 (diff) | |
| download | android-node-v8-e4812d62ebc7830d20872da44cfa4539d7ff0125.tar.gz android-node-v8-e4812d62ebc7830d20872da44cfa4539d7ff0125.tar.bz2 android-node-v8-e4812d62ebc7830d20872da44cfa4539d7ff0125.zip | |
src: fix -Wsign-compare warnings
This commit addresses the following compilation warnings:
../src/node_crypto.cc:5053:3: warning: comparison of integers
of different signs: 'unsigned int' and 'int' [-Wsign-compare]
CHECK_EQ(n, BN_bn2binpad(r, data, n));
../src/node_crypto.cc:5054:3: warning: comparison of integers
of different signs: 'unsigned int' and 'int' [-Wsign-compare]
CHECK_EQ(n, BN_bn2binpad(s, data + n, n));
PR-URL: https://github.com/nodejs/node/pull/30565
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/node_crypto.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node_crypto.cc b/src/node_crypto.cc index fa85f78553..c4fa6e9020 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -5050,8 +5050,8 @@ static AllocatedBuffer ConvertSignatureToP1363(Environment* env, const BIGNUM* r = ECDSA_SIG_get0_r(asn1_sig); const BIGNUM* s = ECDSA_SIG_get0_s(asn1_sig); - CHECK_EQ(n, BN_bn2binpad(r, data, n)); - CHECK_EQ(n, BN_bn2binpad(s, data + n, n)); + CHECK_EQ(n, static_cast<unsigned int>(BN_bn2binpad(r, data, n))); + CHECK_EQ(n, static_cast<unsigned int>(BN_bn2binpad(s, data + n, n))); ECDSA_SIG_free(asn1_sig); |