summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorDaniel Bevenius <daniel.bevenius@gmail.com>2018-07-03 12:28:25 +0200
committerDaniel Bevenius <daniel.bevenius@gmail.com>2018-07-05 06:12:35 +0200
commite021ca28ea6dc87094e97afd3aec6fd8cecd571d (patch)
treefad317b81e9b6815bf61de6b10d9080895e9743f /src
parentb016745e489afb6ac1eb0f14afdf56aeec36469e (diff)
downloadandroid-node-v8-e021ca28ea6dc87094e97afd3aec6fd8cecd571d.tar.gz
android-node-v8-e021ca28ea6dc87094e97afd3aec6fd8cecd571d.tar.bz2
android-node-v8-e021ca28ea6dc87094e97afd3aec6fd8cecd571d.zip
src: remove using directives from spawn_sync.h
I noticed that there were a few using declarations what were unused and instead of just removing them, this commit removes all of them and uses qualified names instead since they are in a header. PR-URL: https://github.com/nodejs/node/pull/21634 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/spawn_sync.h42
1 files changed, 15 insertions, 27 deletions
diff --git a/src/spawn_sync.h b/src/spawn_sync.h
index 8064318466..fed1453296 100644
--- a/src/spawn_sync.h
+++ b/src/spawn_sync.h
@@ -29,18 +29,6 @@
namespace node {
-using v8::Array;
-using v8::Context;
-using v8::FunctionCallbackInfo;
-using v8::HandleScope;
-using v8::Integer;
-using v8::Isolate;
-using v8::Local;
-using v8::Null;
-using v8::Number;
-using v8::Object;
-using v8::String;
-using v8::Value;
class SyncProcessOutputBuffer;
@@ -94,7 +82,7 @@ class SyncProcessStdioPipe {
int Start();
void Close();
- Local<Object> GetOutputAsBuffer(Environment* env) const;
+ v8::Local<v8::Object> GetOutputAsBuffer(Environment* env) const;
inline bool readable() const;
inline bool writable() const;
@@ -151,10 +139,10 @@ class SyncProcessRunner {
};
public:
- static void Initialize(Local<Object> target,
- Local<Value> unused,
- Local<Context> context);
- static void Spawn(const FunctionCallbackInfo<Value>& args);
+ static void Initialize(v8::Local<v8::Object> target,
+ v8::Local<v8::Value> unused,
+ v8::Local<v8::Context> context);
+ static void Spawn(const v8::FunctionCallbackInfo<v8::Value>& args);
private:
friend class SyncProcessStdioPipe;
@@ -164,8 +152,8 @@ class SyncProcessRunner {
inline Environment* env() const;
- Local<Object> Run(Local<Value> options);
- void TryInitializeAndRunLoop(Local<Value> options);
+ v8::Local<v8::Object> Run(v8::Local<v8::Value> options);
+ void TryInitializeAndRunLoop(v8::Local<v8::Value> options);
void CloseHandlesAndDeleteLoop();
void CloseStdioPipes();
@@ -181,12 +169,12 @@ class SyncProcessRunner {
void SetError(int error);
void SetPipeError(int pipe_error);
- Local<Object> BuildResultObject();
- Local<Array> BuildOutputArray();
+ v8::Local<v8::Object> BuildResultObject();
+ v8::Local<v8::Array> BuildOutputArray();
- int ParseOptions(Local<Value> js_value);
- int ParseStdioOptions(Local<Value> js_value);
- int ParseStdioOption(int child_fd, Local<Object> js_stdio_option);
+ int ParseOptions(v8::Local<v8::Value> js_value);
+ int ParseStdioOptions(v8::Local<v8::Value> js_value);
+ int ParseStdioOption(int child_fd, v8::Local<v8::Object> js_stdio_option);
inline int AddStdioIgnore(uint32_t child_fd);
inline int AddStdioPipe(uint32_t child_fd,
@@ -195,9 +183,9 @@ class SyncProcessRunner {
uv_buf_t input_buffer);
inline int AddStdioInheritFD(uint32_t child_fd, int inherit_fd);
- static bool IsSet(Local<Value> value);
- int CopyJsString(Local<Value> js_value, const char** target);
- int CopyJsStringArray(Local<Value> js_value, char** target);
+ static bool IsSet(v8::Local<v8::Value> value);
+ int CopyJsString(v8::Local<v8::Value> js_value, const char** target);
+ int CopyJsStringArray(v8::Local<v8::Value> js_value, char** target);
static void ExitCallback(uv_process_t* handle,
int64_t exit_status,