diff options
author | James M Snell <jasnell@gmail.com> | 2017-10-24 11:39:36 -0700 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2017-10-26 09:49:12 -0700 |
commit | df8c6c3651d29602601310a9219e777084d0d3a9 (patch) | |
tree | 64decc8281ea2e7f4b43984953df3788a63b8d1c /src | |
parent | 33021ba2b05bf27a569016914ec0095758ec2a4c (diff) | |
download | android-node-v8-df8c6c3651d29602601310a9219e777084d0d3a9.tar.gz android-node-v8-df8c6c3651d29602601310a9219e777084d0d3a9.tar.bz2 android-node-v8-df8c6c3651d29602601310a9219e777084d0d3a9.zip |
crypto: use CHECK instead in getSSLCiphers
The previous throws should never happen, and if they do, they
signal a larger issue in core. Make these checks rather than
throws.
PR-URL: https://github.com/nodejs/node/pull/16453
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Diffstat (limited to 'src')
-rw-r--r-- | src/node_crypto.cc | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/src/node_crypto.cc b/src/node_crypto.cc index 45d703cba1..3d114d73d2 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -5613,15 +5613,10 @@ void GetSSLCiphers(const FunctionCallbackInfo<Value>& args) { Environment* env = Environment::GetCurrent(args); SSL_CTX* ctx = SSL_CTX_new(TLSv1_server_method()); - if (ctx == nullptr) { - return env->ThrowError("SSL_CTX_new() failed."); - } + CHECK_NE(ctx, nullptr); SSL* ssl = SSL_new(ctx); - if (ssl == nullptr) { - SSL_CTX_free(ctx); - return env->ThrowError("SSL_new() failed."); - } + CHECK_NE(ssl, nullptr); Local<Array> arr = Array::New(env->isolate()); STACK_OF(SSL_CIPHER)* ciphers = SSL_get_ciphers(ssl); |