diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-11-23 15:25:14 +0100 |
|---|---|---|
| committer | Michael Dawson <michael_dawson@ca.ibm.com> | 2017-11-24 15:23:09 -0500 |
| commit | dc389bf7cc8b297d4f8dd24603ee1793116f3414 (patch) | |
| tree | c45a909ed3b396ec5f1dee23560cf4afcff29acc /src | |
| parent | 9d87082d7df8b509d3e035b0222899d9cd8e58a3 (diff) | |
| download | android-node-v8-dc389bf7cc8b297d4f8dd24603ee1793116f3414.tar.gz android-node-v8-dc389bf7cc8b297d4f8dd24603ee1793116f3414.tar.bz2 android-node-v8-dc389bf7cc8b297d4f8dd24603ee1793116f3414.zip | |
n-api: use nullptr instead of NULL in node_api.cc
This commit changes two checks which use NULL to use nullptr.
I'm not very familiar with N-API but wanted to bring this up in case
it was something that was overlooked.
PR-URL: https://github.com/nodejs/node/pull/17276
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: MichaëZasso <targos@protonmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/node_api.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node_api.cc b/src/node_api.cc index 59ea763512..f16ceefd5e 100644 --- a/src/node_api.cc +++ b/src/node_api.cc @@ -1220,7 +1220,7 @@ napi_status napi_delete_property(napi_env env, v8::Maybe<bool> delete_maybe = obj->Delete(context, k); CHECK_MAYBE_NOTHING(env, delete_maybe, napi_generic_failure); - if (result != NULL) + if (result != nullptr) *result = delete_maybe.FromMaybe(false); return GET_RETURN_STATUS(env); @@ -1398,7 +1398,7 @@ napi_status napi_delete_element(napi_env env, v8::Maybe<bool> delete_maybe = obj->Delete(context, index); CHECK_MAYBE_NOTHING(env, delete_maybe, napi_generic_failure); - if (result != NULL) + if (result != nullptr) *result = delete_maybe.FromMaybe(false); return GET_RETURN_STATUS(env); |