diff options
| author | Myles Borins <mylesborins@google.com> | 2018-01-25 14:32:43 -0800 |
|---|---|---|
| committer | Myles Borins <mylesborins@google.com> | 2018-01-31 16:05:23 -0800 |
| commit | ba3d55a3b88cfdc9755b492912616ddd1931c4a3 (patch) | |
| tree | a86899aa718a5f9513fe83a2b98b8874ebb332fb /src | |
| parent | 6bcd31f2f4a518f70646a72e7a6e42aa6ca90469 (diff) | |
| download | android-node-v8-ba3d55a3b88cfdc9755b492912616ddd1931c4a3.tar.gz android-node-v8-ba3d55a3b88cfdc9755b492912616ddd1931c4a3.tar.bz2 android-node-v8-ba3d55a3b88cfdc9755b492912616ddd1931c4a3.zip | |
module: enable dynamic import flag for esmodules
currently if you want to use dynamic import you must use both the
`--experimental-modules` and the `--harmony-dynamic-imports` flags.
Chrome is currently shipping dynamic import unflagged, the flag
only remains in V8 to guard embedders who have not set the appropriate
callback from throwing an unhandled rejection when the feature is used.
As such it is reasonable to enable the flag by default for
`--experimental-modules`
PR-URL: https://github.com/nodejs/node/pull/18387
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/node.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/node.cc b/src/node.cc index bcb764e400..e86e48060c 100644 --- a/src/node.cc +++ b/src/node.cc @@ -3678,6 +3678,8 @@ static void ParseArgs(int* argc, config_preserve_symlinks = true; } else if (strcmp(arg, "--experimental-modules") == 0) { config_experimental_modules = true; + new_v8_argv[new_v8_argc] = "--harmony-dynamic-import"; + new_v8_argc += 1; } else if (strcmp(arg, "--experimental-vm-modules") == 0) { config_experimental_vm_modules = true; } else if (strcmp(arg, "--loader") == 0) { |