diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-03-20 19:45:28 +0800 |
---|---|---|
committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-03-27 10:30:16 -0400 |
commit | 9f37d3c114b2c4233e58bdce8d82a06cac467738 (patch) | |
tree | d716c4158ace5e38a7092da9027b7c85867188d1 /src | |
parent | 242466167d6379791858ce59ca11d823c2eb4469 (diff) | |
download | android-node-v8-9f37d3c114b2c4233e58bdce8d82a06cac467738.tar.gz android-node-v8-9f37d3c114b2c4233e58bdce8d82a06cac467738.tar.bz2 android-node-v8-9f37d3c114b2c4233e58bdce8d82a06cac467738.zip |
src: move TrackingTraceStateObserver out of Environment
PR-URL: https://github.com/nodejs/node/pull/26824
Refs: https://github.com/nodejs/node/issues/26776
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src')
-rw-r--r-- | src/env.cc | 2 | ||||
-rw-r--r-- | src/env.h | 38 |
2 files changed, 20 insertions, 20 deletions
diff --git a/src/env.cc b/src/env.cc index 608bada5d7..f13af94db9 100644 --- a/src/env.cc +++ b/src/env.cc @@ -119,7 +119,7 @@ void InitThreadLocalOnce() { CHECK_EQ(0, uv_key_create(&Environment::thread_local_env)); } -void Environment::TrackingTraceStateObserver::UpdateTraceCategoryState() { +void TrackingTraceStateObserver::UpdateTraceCategoryState() { if (!env_->owns_process_state()) { // Ideally, we’d have a consistent story that treats all threads/Environment // instances equally here. However, tracing is essentially global, and this @@ -665,6 +665,25 @@ class TickInfo { AliasedBuffer<uint8_t, v8::Uint8Array> fields_; }; +class TrackingTraceStateObserver : + public v8::TracingController::TraceStateObserver { + public: + explicit TrackingTraceStateObserver(Environment* env) : env_(env) {} + + void OnTraceEnabled() override { + UpdateTraceCategoryState(); + } + + void OnTraceDisabled() override { + UpdateTraceCategoryState(); + } + + private: + void UpdateTraceCategoryState(); + + Environment* env_; +}; + class Environment { public: Environment(const Environment&) = delete; @@ -979,25 +998,6 @@ class Environment { // This needs to be available for the JS-land setImmediate(). void ToggleImmediateRef(bool ref); - class TrackingTraceStateObserver : - public v8::TracingController::TraceStateObserver { - public: - explicit TrackingTraceStateObserver(Environment* env) : env_(env) {} - - void OnTraceEnabled() override { - UpdateTraceCategoryState(); - } - - void OnTraceDisabled() override { - UpdateTraceCategoryState(); - } - - private: - void UpdateTraceCategoryState(); - - Environment* env_; - }; - class ShouldNotAbortOnUncaughtScope { public: explicit inline ShouldNotAbortOnUncaughtScope(Environment* env); |