diff options
| author | gengjiawen <technicalcute@gmail.com> | 2019-03-20 20:55:22 +0800 |
|---|---|---|
| committer | Refael Ackermann <refack@gmail.com> | 2019-03-22 18:14:37 -0400 |
| commit | 86e02966318531ddf7279c88821233c64aa7bf4c (patch) | |
| tree | 3237b474c34c26daf7401b64b52bfa25e2540ae7 /src | |
| parent | 7d201c4e700ff94f17dab9185c03c44597976e8c (diff) | |
| download | android-node-v8-86e02966318531ddf7279c88821233c64aa7bf4c.tar.gz android-node-v8-86e02966318531ddf7279c88821233c64aa7bf4c.tar.bz2 android-node-v8-86e02966318531ddf7279c88821233c64aa7bf4c.zip | |
src: apply clang-tidy performance-faster-string-find
PR-URL: https://github.com/nodejs/node/pull/26812
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/inspector_socket.cc | 4 | ||||
| -rw-r--r-- | src/node_report.cc | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/inspector_socket.cc b/src/inspector_socket.cc index 161e93c0af..a7019281af 100644 --- a/src/inspector_socket.cc +++ b/src/inspector_socket.cc @@ -156,10 +156,10 @@ static void generate_accept_string(const std::string& client_key, } static std::string TrimPort(const std::string& host) { - size_t last_colon_pos = host.rfind(":"); + size_t last_colon_pos = host.rfind(':'); if (last_colon_pos == std::string::npos) return host; - size_t bracket = host.rfind("]"); + size_t bracket = host.rfind(']'); if (bracket == std::string::npos || last_colon_pos > bracket) return host.substr(0, last_colon_pos); return host; diff --git a/src/node_report.cc b/src/node_report.cc index 00d6a2454c..f9cf921143 100644 --- a/src/node_report.cc +++ b/src/node_report.cc @@ -507,7 +507,7 @@ static void PrintSystemInformation(JSONWriter* writer) { WideCharToMultiByte( CP_UTF8, 0, lpszVariable, -1, str, size, nullptr, nullptr); std::string env(str); - int sep = env.rfind("="); + int sep = env.rfind('='); std::string key = env.substr(0, sep); std::string value = env.substr(sep + 1); writer->json_keyvalue(key, value); |