diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-11-26 19:40:09 +0900 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-11-29 11:18:39 -0800 |
| commit | 83d6cb98ecf6efc0792b174265a4580b31f4b3eb (patch) | |
| tree | bef773a862eee0add454ff1c70863bb609a0738b /src | |
| parent | 9efcfd313ad965f04d26abe33468569a82815485 (diff) | |
| download | android-node-v8-83d6cb98ecf6efc0792b174265a4580b31f4b3eb.tar.gz android-node-v8-83d6cb98ecf6efc0792b174265a4580b31f4b3eb.tar.bz2 android-node-v8-83d6cb98ecf6efc0792b174265a4580b31f4b3eb.zip | |
process: fix omitting `--` from `process.execArgv`
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.
Fixes: https://github.com/nodejs/node/issues/24647
PR-URL: https://github.com/nodejs/node/pull/24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/node_options-inl.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_options-inl.h b/src/node_options-inl.h index 277121036e..468368ac84 100644 --- a/src/node_options-inl.h +++ b/src/node_options-inl.h @@ -253,7 +253,7 @@ struct ArgsInfo { // on the command line (i.e. not generated through alias expansion). // '--' is a special case here since its purpose is to end `exec_argv`, // which is why we do not include it. - if (exec_args != nullptr && first() != "--") + if (exec_args != nullptr && ret != "--") exec_args->push_back(ret); underlying->erase(underlying->begin() + 1); } else { |