summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorBenedikt Meurer <bmeurer@chromium.org>2018-07-05 09:42:52 +0200
committerMichaƫl Zasso <targos@protonmail.com>2018-07-19 08:49:18 +0200
commit756f63e1e4d19164c56075b0d52ecc7fbfd4fe69 (patch)
treec56b511a14fe63ab89d0dce459ef1cd42bdac13d /src
parentdf08779e0dfa82ceb69e129ae0548e97352aaddf (diff)
downloadandroid-node-v8-756f63e1e4d19164c56075b0d52ecc7fbfd4fe69.tar.gz
android-node-v8-756f63e1e4d19164c56075b0d52ecc7fbfd4fe69.tar.bz2
android-node-v8-756f63e1e4d19164c56075b0d52ecc7fbfd4fe69.zip
src: prepare for V8 Swallowed Rejection Hook
This is done in preparation for landing https://chromium-review.googlesource.com/c/v8/v8/+/1126099 on the V8 side, which extends the existing PromiseRejectEvent mechanism with new hooks for reject/resolve after a Promise was previously resolved already. Refs: https://github.com/nodejs/promises-debugging/issues/8 Design: https://goo.gl/2stLUY PR-URL: https://github.com/nodejs/node/pull/21838 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/bootstrapper.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 8bcc0493f5..5f40d62a82 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -69,7 +69,7 @@ void PromiseRejectCallback(PromiseRejectMessage message) {
callback = env->promise_reject_handled_function();
value = Undefined(isolate);
} else {
- UNREACHABLE();
+ return;
}
Local<Value> args[] = { promise, value };