diff options
| author | Jon Moss <me@jonathanmoss.me> | 2018-08-09 10:58:30 -0400 |
|---|---|---|
| committer | Jon Moss <me@jonathanmoss.me> | 2018-08-11 20:22:10 -0400 |
| commit | 640dc7a474b071503f5a2067e1de49592cd128b0 (patch) | |
| tree | ded8ea3531ba52163b97168c07eb8d9cad67df74 /src | |
| parent | a5b3c15b77d1bf4b12e1e277c7814a12c2101c61 (diff) | |
| download | android-node-v8-640dc7a474b071503f5a2067e1de49592cd128b0.tar.gz android-node-v8-640dc7a474b071503f5a2067e1de49592cd128b0.tar.bz2 android-node-v8-640dc7a474b071503f5a2067e1de49592cd128b0.zip | |
crypto: remove unused SSLWrap handle methods
One was not used at all, and the other was only used in a test, which I
converted to use the more standard `ShutdownWrap` API.
PR-URL: https://github.com/nodejs/node/pull/22216
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/node_crypto.cc | 21 |
1 files changed, 0 insertions, 21 deletions
diff --git a/src/node_crypto.cc b/src/node_crypto.cc index 51c2fe2648..39bcd4cab6 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -1381,13 +1381,11 @@ void SSLWrap<Base>::AddMethods(Environment* env, Local<FunctionTemplate> t) { env->SetProtoMethod(t, "setSession", SetSession); env->SetProtoMethod(t, "loadSession", LoadSession); env->SetProtoMethodNoSideEffect(t, "isSessionReused", IsSessionReused); - env->SetProtoMethodNoSideEffect(t, "isInitFinished", IsInitFinished); env->SetProtoMethodNoSideEffect(t, "verifyError", VerifyError); env->SetProtoMethodNoSideEffect(t, "getCurrentCipher", GetCurrentCipher); env->SetProtoMethod(t, "endParser", EndParser); env->SetProtoMethod(t, "certCbDone", CertCbDone); env->SetProtoMethod(t, "renegotiate", Renegotiate); - env->SetProtoMethod(t, "shutdownSSL", Shutdown); env->SetProtoMethodNoSideEffect(t, "getTLSTicket", GetTLSTicket); env->SetProtoMethod(t, "newSessionDone", NewSessionDone); env->SetProtoMethod(t, "setOCSPResponse", SetOCSPResponse); @@ -1994,16 +1992,6 @@ void SSLWrap<Base>::Renegotiate(const FunctionCallbackInfo<Value>& args) { template <class Base> -void SSLWrap<Base>::Shutdown(const FunctionCallbackInfo<Value>& args) { - Base* w; - ASSIGN_OR_RETURN_UNWRAP(&w, args.Holder()); - - int rv = SSL_shutdown(w->ssl_.get()); - args.GetReturnValue().Set(rv); -} - - -template <class Base> void SSLWrap<Base>::GetTLSTicket(const FunctionCallbackInfo<Value>& args) { Base* w; ASSIGN_OR_RETURN_UNWRAP(&w, args.Holder()); @@ -2137,15 +2125,6 @@ void SSLWrap<Base>::SetMaxSendFragment( template <class Base> -void SSLWrap<Base>::IsInitFinished(const FunctionCallbackInfo<Value>& args) { - Base* w; - ASSIGN_OR_RETURN_UNWRAP(&w, args.Holder()); - bool yes = SSL_is_init_finished(w->ssl_.get()); - args.GetReturnValue().Set(yes); -} - - -template <class Base> void SSLWrap<Base>::VerifyError(const FunctionCallbackInfo<Value>& args) { Base* w; ASSIGN_OR_RETURN_UNWRAP(&w, args.Holder()); |