diff options
| author | Timothy Gu <timothygu99@gmail.com> | 2018-06-24 15:30:17 -0400 |
|---|---|---|
| committer | Timothy Gu <timothygu99@gmail.com> | 2018-06-24 18:02:10 -0400 |
| commit | 6396574cde50631b5b6616fdf7c499a82b468d65 (patch) | |
| tree | cae7f06c69bf917b38b879a52fc10f465818ff35 /src | |
| parent | 28100bbe6d3012a25fb9036c742c4bf1f13aeeb8 (diff) | |
| download | android-node-v8-6396574cde50631b5b6616fdf7c499a82b468d65.tar.gz android-node-v8-6396574cde50631b5b6616fdf7c499a82b468d65.tar.bz2 android-node-v8-6396574cde50631b5b6616fdf7c499a82b468d65.zip | |
crypto: remove outdated comment
PR-URL: https://github.com/nodejs/node/pull/21511
Fixes: https://github.com/nodejs/node/issues/21488
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/node_crypto.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/node_crypto.cc b/src/node_crypto.cc index 8b152e65c3..9b65386387 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -2154,9 +2154,6 @@ void SSLWrap<Base>::VerifyError(const FunctionCallbackInfo<Value>& args) { if (x509_verify_error == X509_V_OK) return args.GetReturnValue().SetNull(); - // XXX(bnoordhuis) X509_verify_cert_error_string() is not actually thread-safe - // in the presence of invalid error codes. Probably academical but something - // to keep in mind if/when node ever grows multi-isolate capabilities. const char* reason = X509_verify_cert_error_string(x509_verify_error); const char* code = reason; #define CASE_X509_ERR(CODE) case X509_V_ERR_##CODE: code = #CODE; break; |