summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorJeremy Apthorp <nornagon@nornagon.net>2019-10-25 14:52:13 -0700
committerAnna Henningsen <anna@addaleax.net>2019-11-19 16:03:55 +0100
commit4f434187ff06cc8ac9e2022e65d6f6bf2fb8a19e (patch)
tree202bedfd5c4c2e6430c2c8e37921a30d52b707db /src
parent7cecac669f05f36016c684dcee381cf21ab188d2 (diff)
downloadandroid-node-v8-4f434187ff06cc8ac9e2022e65d6f6bf2fb8a19e.tar.gz
android-node-v8-4f434187ff06cc8ac9e2022e65d6f6bf2fb8a19e.tar.bz2
android-node-v8-4f434187ff06cc8ac9e2022e65d6f6bf2fb8a19e.zip
src: add file name to 'Module did not self-register' error
PR-URL: https://github.com/nodejs/node/pull/30125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Diffstat (limited to 'src')
-rw-r--r--src/node_binding.cc7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/node_binding.cc b/src/node_binding.cc
index d083c64d10..f57ddb54b6 100644
--- a/src/node_binding.cc
+++ b/src/node_binding.cc
@@ -484,7 +484,12 @@ void DLOpen(const FunctionCallbackInfo<Value>& args) {
mp = dlib->GetSavedModuleFromGlobalHandleMap();
if (mp == nullptr || mp->nm_context_register_func == nullptr) {
dlib->Close();
- env->ThrowError("Module did not self-register.");
+ char errmsg[1024];
+ snprintf(errmsg,
+ sizeof(errmsg),
+ "Module did not self-register: '%s'.",
+ *filename);
+ env->ThrowError(errmsg);
return false;
}
}