diff options
| author | Tobias Nießen <tniessen@tnie.de> | 2018-10-13 19:23:07 +0200 |
|---|---|---|
| committer | Tobias Nießen <tniessen@tnie.de> | 2018-10-17 18:45:26 +0200 |
| commit | 4e2862ad9e7fa3ba48467ccd7a61f4e06d71298d (patch) | |
| tree | 41fe05beff3d456d0ce38f42546dd100b8a0c2ef /src | |
| parent | 7872d7933be571dabfa94259433612a34b885513 (diff) | |
| download | android-node-v8-4e2862ad9e7fa3ba48467ccd7a61f4e06d71298d.tar.gz android-node-v8-4e2862ad9e7fa3ba48467ccd7a61f4e06d71298d.tar.bz2 android-node-v8-4e2862ad9e7fa3ba48467ccd7a61f4e06d71298d.zip | |
crypto: simplify error handling in ECDH::New
The type of the argument is being checked within JS which makes the
type checking in C++ unnecessary.
PR-URL: https://github.com/nodejs/node/pull/23647
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'src')
| -rw-r--r-- | src/node_crypto.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_crypto.cc b/src/node_crypto.cc index 088483686d..89ec7f7d14 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -4342,7 +4342,7 @@ void ECDH::New(const FunctionCallbackInfo<Value>& args) { MarkPopErrorOnReturn mark_pop_error_on_return; // TODO(indutny): Support raw curves? - THROW_AND_RETURN_IF_NOT_STRING(env, args[0], "ECDH curve name"); + CHECK(args[0]->IsString()); node::Utf8Value curve(env->isolate(), args[0]); int nid = OBJ_sn2nid(*curve); |