diff options
| author | Jan Krems <jan.krems@groupon.com> | 2017-04-03 15:16:39 -0700 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2017-04-06 09:50:09 +0200 |
| commit | 47f8f7462fb198aa27ede602c43786bdbfda37a2 (patch) | |
| tree | 2304f9b323c07f807a498610bca2c07c136c858d /src | |
| parent | e139dae157cca968e89de51ad435ded23f2b8be1 (diff) | |
| download | android-node-v8-47f8f7462fb198aa27ede602c43786bdbfda37a2.tar.gz android-node-v8-47f8f7462fb198aa27ede602c43786bdbfda37a2.tar.bz2 android-node-v8-47f8f7462fb198aa27ede602c43786bdbfda37a2.zip | |
src: remove support for --debug
In the 2017-04-05 meeting, the CTC agreed to remove support for the
legacy debugger in 8.0.0. This is the first step in this direction.
Refs: https://github.com/nodejs/CTC/issues/94
PR-URL: https://github.com/nodejs/node/pull/12197
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/node_debug_options.cc | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/src/node_debug_options.cc b/src/node_debug_options.cc index 410e23acb3..97f9dce1b7 100644 --- a/src/node_debug_options.cc +++ b/src/node_debug_options.cc @@ -92,13 +92,7 @@ bool DebugOptions::ParseOption(const std::string& option) { argument = option.substr(pos + 1); } - // --debug and --inspect are mutually exclusive - if (option_name == "--debug") { - debugger_enabled_ = true; - } else if (option_name == "--debug-brk") { - debugger_enabled_ = true; - wait_connect_ = true; - } else if (option_name == "--inspect") { + if (option_name == "--inspect") { debugger_enabled_ = true; enable_inspector = true; } else if (option_name == "--inspect-brk") { @@ -108,7 +102,7 @@ bool DebugOptions::ParseOption(const std::string& option) { } else if ((option_name != "--debug-port" && option_name != "--inspect-port") || !has_argument) { - // only other valid possibility is --debug-port, + // only other valid possibility is --inspect-port, // which requires an argument return false; } |