diff options
| author | cjihrig <cjihrig@gmail.com> | 2019-11-19 15:05:09 -0500 |
|---|---|---|
| committer | cjihrig <cjihrig@gmail.com> | 2019-11-20 13:48:01 -0500 |
| commit | 3871cc5f0c791632d2555e159873530bfdd02d4f (patch) | |
| tree | 792f994a740c4afd128af6530999ca6379b8b3aa /src | |
| parent | c712fb7cd6222018cf615fd0071998bde6f16da9 (diff) | |
| download | android-node-v8-3871cc5f0c791632d2555e159873530bfdd02d4f.tar.gz android-node-v8-3871cc5f0c791632d2555e159873530bfdd02d4f.tar.bz2 android-node-v8-3871cc5f0c791632d2555e159873530bfdd02d4f.zip | |
src: fix -Winconsistent-missing-override warning
This commit addresses the following warning:
../src/node_api.cc:28:19: warning: 'mark_arraybuffer_as_untransferable'
overrides a member function but is not marked 'override'
[-Winconsistent-missing-override]
v8::Maybe<bool> mark_arraybuffer_as_untransferable(
^
../src/js_native_api_v8.h:42:27: note: overridden virtual function is here
virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable(
PR-URL: https://github.com/nodejs/node/pull/30549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/node_api.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_api.cc b/src/node_api.cc index b293272b91..8df4559c6c 100644 --- a/src/node_api.cc +++ b/src/node_api.cc @@ -26,7 +26,7 @@ struct node_napi_env__ : public napi_env__ { } v8::Maybe<bool> mark_arraybuffer_as_untransferable( - v8::Local<v8::ArrayBuffer> ab) const { + v8::Local<v8::ArrayBuffer> ab) const override { return ab->SetPrivate( context(), node_env()->arraybuffer_untransferable_private_symbol(), |