diff options
| author | Tobias Nießen <tniessen@tnie.de> | 2019-09-08 19:19:35 +0200 |
|---|---|---|
| committer | Tobias Nießen <tniessen@tnie.de> | 2019-09-13 16:58:56 +0200 |
| commit | 3675f402ab1114675c5be7950d38b7e168ba5771 (patch) | |
| tree | 0351d40c50dcd7b2f6d8c7abeda96f3f8b364162 /src | |
| parent | b64446648b61085715908b2769bbdfee7b2c84e4 (diff) | |
| download | android-node-v8-3675f402ab1114675c5be7950d38b7e168ba5771.tar.gz android-node-v8-3675f402ab1114675c5be7950d38b7e168ba5771.tar.bz2 android-node-v8-3675f402ab1114675c5be7950d38b7e168ba5771.zip | |
crypto: fix OpenSSL return code handling
PR-URL: https://github.com/nodejs/node/pull/29489
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/node_crypto.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/node_crypto.cc b/src/node_crypto.cc index 40dad6827b..9939123f9f 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -5218,7 +5218,7 @@ bool PublicKeyCipher::Cipher(Environment* env, return false; if (digest != nullptr) { - if (!EVP_PKEY_CTX_set_rsa_oaep_md(ctx.get(), digest)) + if (EVP_PKEY_CTX_set_rsa_oaep_md(ctx.get(), digest) <= 0) return false; } @@ -5226,7 +5226,8 @@ bool PublicKeyCipher::Cipher(Environment* env, // OpenSSL takes ownership of the label, so we need to create a copy. void* label = OPENSSL_memdup(oaep_label, oaep_label_len); CHECK_NOT_NULL(label); - if (!EVP_PKEY_CTX_set0_rsa_oaep_label(ctx.get(), label, oaep_label_len)) { + if (0 >= EVP_PKEY_CTX_set0_rsa_oaep_label(ctx.get(), label, + oaep_label_len)) { OPENSSL_free(label); return false; } |