summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorSam Roberts <vieuxtech@gmail.com>2019-01-31 13:51:20 -0800
committerSam Roberts <vieuxtech@gmail.com>2019-02-05 15:16:34 -0800
commit24ea4a345239670d546ea80723f4f203aa6fcdf4 (patch)
treec8dd51639bce47dc9182ffbe08eddcbe16ef5926 /src
parent73b204cd2b02ba021df108fb2f916b51d844c1c9 (diff)
downloadandroid-node-v8-24ea4a345239670d546ea80723f4f203aa6fcdf4.tar.gz
android-node-v8-24ea4a345239670d546ea80723f4f203aa6fcdf4.tar.bz2
android-node-v8-24ea4a345239670d546ea80723f4f203aa6fcdf4.zip
src: organize TLSWrap declarations by parent
Make it clear which of the multiple interfaces a TLSWrap method is implementing by grouping and commenting the related methods. PR-URL: https://github.com/nodejs/node/pull/25861 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'src')
-rw-r--r--src/tls_wrap.h25
1 files changed, 13 insertions, 12 deletions
diff --git a/src/tls_wrap.h b/src/tls_wrap.h
index be96e76503..cc91c2edc7 100644
--- a/src/tls_wrap.h
+++ b/src/tls_wrap.h
@@ -57,16 +57,19 @@ class TLSWrap : public AsyncWrap,
v8::Local<v8::Context> context,
void* priv);
- int GetFD() override;
+ // Implement StreamBase:
bool IsAlive() override;
bool IsClosing() override;
-
- // JavaScript functions
- int ReadStart() override;
- int ReadStop() override;
-
+ bool IsIPCPipe() override;
+ int GetFD() override;
ShutdownWrap* CreateShutdownWrap(
v8::Local<v8::Object> req_wrap_object) override;
+ AsyncWrap* GetAsyncWrap() override;
+
+
+ // Implement StreamResource:
+ int ReadStart() override; // Exposed to JS
+ int ReadStop() override; // Exposed to JS
int DoShutdown(ShutdownWrap* req_wrap) override;
int DoWrite(WriteWrap* w,
uv_buf_t* bufs,
@@ -79,8 +82,8 @@ class TLSWrap : public AsyncWrap,
void NewSessionDoneCb();
+ // Implement MemoryRetainer:
void MemoryInfo(MemoryTracker* tracker) const override;
-
SET_MEMORY_INFO_NAME(TLSWrap)
SET_SELF_SIZE(TLSWrap)
@@ -136,13 +139,11 @@ class TLSWrap : public AsyncWrap,
}
}
- AsyncWrap* GetAsyncWrap() override;
- bool IsIPCPipe() override;
-
- // Resource implementation
- void OnStreamAfterWrite(WriteWrap* w, int status) override;
+ // Implement StreamListener:
+ // Returns buf that points into enc_in_.
uv_buf_t OnStreamAlloc(size_t size) override;
void OnStreamRead(ssize_t nread, const uv_buf_t& buf) override;
+ void OnStreamAfterWrite(WriteWrap* w, int status) override;
v8::Local<v8::Value> GetSSLError(int status, int* err, std::string* msg);