diff options
| author | Bruce A. MacNaughton <bmacnaughton@gmail.com> | 2018-10-12 11:20:55 -0700 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-10-14 22:21:39 +0200 |
| commit | 20b3698ac14fdd9664654fa90302a5f8b6b58193 (patch) | |
| tree | 94ce0046ad4d15f2ee09f16187b9dff141421ba4 /src | |
| parent | 541367ac8e17619f4d11af836f41bc18a789623b (diff) | |
| download | android-node-v8-20b3698ac14fdd9664654fa90302a5f8b6b58193.tar.gz android-node-v8-20b3698ac14fdd9664654fa90302a5f8b6b58193.tar.bz2 android-node-v8-20b3698ac14fdd9664654fa90302a5f8b6b58193.zip | |
src: throw if functions used as constructors in node_crypto.cc
Throw an error if verify_error_getter_templ or
verify_error_getter_templ2 are used as constructors.
PR-URL: https://github.com/nodejs/node/pull/23582
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/node_crypto.cc | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/node_crypto.cc b/src/node_crypto.cc index 627c14360e..7d2cba2257 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -3940,8 +3940,7 @@ void DiffieHellman::Initialize(Environment* env, Local<Object> target) { env->as_external(), Signature::New(env->isolate(), t), /* length */ 0, - // TODO(TimothyGu): should be deny - ConstructorBehavior::kAllow, + ConstructorBehavior::kThrow, SideEffectType::kHasNoSideEffect); t->InstanceTemplate()->SetAccessorProperty( @@ -3969,8 +3968,7 @@ void DiffieHellman::Initialize(Environment* env, Local<Object> target) { env->as_external(), Signature::New(env->isolate(), t2), /* length */ 0, - // TODO(TimothyGu): should be deny - ConstructorBehavior::kAllow, + ConstructorBehavior::kThrow, SideEffectType::kHasNoSideEffect); t2->InstanceTemplate()->SetAccessorProperty( |