summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorShelley Vohr <shelley.vohr@gmail.com>2019-10-23 11:06:57 -0700
committerShelley Vohr <shelley.vohr@gmail.com>2019-10-28 08:15:08 -0700
commit1d89c5d1e16d67962db2735efc601b48bd78255d (patch)
treed6f2ec8fca92b22d178fab89428d0a873fc47316 /src
parent511f67bcb42b59c9a3a3efab8fed578db100afe1 (diff)
downloadandroid-node-v8-1d89c5d1e16d67962db2735efc601b48bd78255d.tar.gz
android-node-v8-1d89c5d1e16d67962db2735efc601b48bd78255d.tar.bz2
android-node-v8-1d89c5d1e16d67962db2735efc601b48bd78255d.zip
cli: whitelist new V8 flag in NODE_OPTIONS
Explicitly whitelists --disallow-code-generation-from-strings in NODE_OPTIONS as a new V8 flag. This flag prevents strings like eval() from performing code generation. PR-URL: https://github.com/nodejs/node/pull/30094 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/node_options.cc4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/node_options.cc b/src/node_options.cc
index 8ec469d3ac..695d7cee65 100644
--- a/src/node_options.cc
+++ b/src/node_options.cc
@@ -589,6 +589,10 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
V8Option{},
kAllowedInEnvironment);
AddOption("--stack-trace-limit", "", V8Option{}, kAllowedInEnvironment);
+ AddOption("--disallow-code-generation-from-strings",
+ "disallow eval and friends",
+ V8Option{},
+ kAllowedInEnvironment);
#ifdef NODE_REPORT
AddOption("--report-uncaught-exception",