src: refactor default trace writer out of agent

The agent code is supposed to manage multiple writers/clients.
Adding the default writer into the mix breaks that encapsulation.
Instead, manage default options through a separate "virtual"
default client handle, and keep the file writer management
all to the actual users.

PR-URL: https://github.com/nodejs/node/pull/21867
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

1 files changed, 14 insertions, 0 deletions

diff --git a/src/util.cc b/src/util.cc
index 3e808e13fe..66be18eae2 100644
--- a/src/util.cc
+++ b/src/util.cc
@@ -24,6 +24,7 @@
 #include "node_internals.h"
 #include "uv.h"
 #include <stdio.h>
+#include <sstream>
 
 namespace node {
 
@@ -118,4 +119,17 @@ void GetHumanReadableProcessName(char (*name)[1024]) {
   snprintf(*name, sizeof(*name), "%s[%d]", title, uv_os_getpid());
 }
 
+std::set<std::string> ParseCommaSeparatedSet(const std::string& in) {
+  std::set<std::string> out;
+  if (in.empty())
+    return out;
+  std::istringstream in_stream(in);
+  while (in_stream.good()) {
+    std::string item;
+    getline(in_stream, item, ',');
+    out.emplace(std::move(item));
+  }
+  return out;
+}
+
 }  // namespace node