diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-09-23 19:24:33 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-10-03 13:43:42 -0700 |
| commit | d527dde3600655eae7ce0ba5da9263ec4560cd11 (patch) | |
| tree | cb9186b8b85a696ec7f916f40fcec935ba86fdc9 /src/udp_wrap.cc | |
| parent | 2ebdba12297348649620e3d302b156c149d85a6e (diff) | |
| download | android-node-v8-d527dde3600655eae7ce0ba5da9263ec4560cd11.tar.gz android-node-v8-d527dde3600655eae7ce0ba5da9263ec4560cd11.tar.bz2 android-node-v8-d527dde3600655eae7ce0ba5da9263ec4560cd11.zip | |
src: use JS inheritance for `AsyncWrap`
For all classes descending from `AsyncWrap`, use JS inheritance
instead of manually adding methods to the individual classes.
This allows cleanup of some code around transferring handles
over IPC.
PR-URL: https://github.com/nodejs/node/pull/23094
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/udp_wrap.cc')
| -rw-r--r-- | src/udp_wrap.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/udp_wrap.cc b/src/udp_wrap.cc index 510926abde..77139c2f93 100644 --- a/src/udp_wrap.cc +++ b/src/udp_wrap.cc @@ -135,8 +135,7 @@ void UDPWrap::Initialize(Local<Object> target, env->SetProtoMethod(t, "setTTL", SetTTL); env->SetProtoMethod(t, "bufferSize", BufferSize); - AsyncWrap::AddWrapMethods(env, t); - HandleWrap::AddWrapMethods(env, t); + t->Inherit(HandleWrap::GetConstructorTemplate(env)); target->Set(udpString, t->GetFunction(env->context()).ToLocalChecked()); env->set_udp_constructor_function( @@ -145,7 +144,7 @@ void UDPWrap::Initialize(Local<Object> target, // Create FunctionTemplate for SendWrap Local<FunctionTemplate> swt = BaseObject::MakeLazilyInitializedJSTemplate(env); - AsyncWrap::AddWrapMethods(env, swt); + swt->Inherit(AsyncWrap::GetConstructorTemplate(env)); Local<String> sendWrapString = FIXED_ONE_BYTE_STRING(env->isolate(), "SendWrap"); swt->SetClassName(sendWrapString); |