diff options
| author | Timothy Gu <timothygu99@gmail.com> | 2018-06-22 01:25:12 -0400 |
|---|---|---|
| committer | Timothy Gu <timothygu99@gmail.com> | 2018-06-25 23:15:35 -0400 |
| commit | 65f617314d1ea2df8b9e16fb7e7078b5913c749c (patch) | |
| tree | 719a8cf6099c336eddf75af226ca1bfbd0b73965 /src/tty_wrap.cc | |
| parent | cd8adfaf98613fb0ae4ba71018a236906f67f286 (diff) | |
| download | android-node-v8-65f617314d1ea2df8b9e16fb7e7078b5913c749c.tar.gz android-node-v8-65f617314d1ea2df8b9e16fb7e7078b5913c749c.tar.bz2 android-node-v8-65f617314d1ea2df8b9e16fb7e7078b5913c749c.zip | |
src: start annotating native code side effect
PR-URL: https://github.com/nodejs/node/pull/21458
Refs: https://github.com/nodejs/node/issues/20977
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/tty_wrap.cc')
| -rw-r--r-- | src/tty_wrap.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/tty_wrap.cc b/src/tty_wrap.cc index 175b32879b..83b6e34d63 100644 --- a/src/tty_wrap.cc +++ b/src/tty_wrap.cc @@ -58,15 +58,15 @@ void TTYWrap::Initialize(Local<Object> target, env->SetProtoMethod(t, "close", HandleWrap::Close); env->SetProtoMethod(t, "unref", HandleWrap::Unref); env->SetProtoMethod(t, "ref", HandleWrap::Ref); - env->SetProtoMethod(t, "hasRef", HandleWrap::HasRef); + env->SetProtoMethodNoSideEffect(t, "hasRef", HandleWrap::HasRef); LibuvStreamWrap::AddMethods(env, t); - env->SetProtoMethod(t, "getWindowSize", TTYWrap::GetWindowSize); + env->SetProtoMethodNoSideEffect(t, "getWindowSize", TTYWrap::GetWindowSize); env->SetProtoMethod(t, "setRawMode", SetRawMode); - env->SetMethod(target, "isTTY", IsTTY); - env->SetMethod(target, "guessHandleType", GuessHandleType); + env->SetMethodNoSideEffect(target, "isTTY", IsTTY); + env->SetMethodNoSideEffect(target, "guessHandleType", GuessHandleType); target->Set(ttyString, t->GetFunction()); env->set_tty_constructor_template(t); |