tty_wrap: throw when uv_tty_init() returns error

Also add checks in lib/tty.js and tests.

PR-URL: https://github.com/nodejs/node/pull/12892
Ref: https://github.com/nodejs/node/pull/11883
Ref: https://github.com/nodejs/node/pull/8531
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

1 files changed, 11 insertions, 3 deletions

diff --git a/src/tty_wrap.cc b/src/tty_wrap.cc
index 82476e755d..b6e3efcc10 100644
--- a/src/tty_wrap.cc
+++ b/src/tty_wrap.cc
@@ -150,17 +150,25 @@ void TTYWrap::New(const FunctionCallbackInfo<Value>& args) {
   int fd = args[0]->Int32Value();
   CHECK_GE(fd, 0);
 
-  TTYWrap* wrap = new TTYWrap(env, args.This(), fd, args[1]->IsTrue());
+  int err = 0;
+  TTYWrap* wrap = new TTYWrap(env, args.This(), fd, args[1]->IsTrue(), &err);
+  if (err != 0)
+    return env->ThrowUVException(err, "uv_tty_init");
+
   wrap->UpdateWriteQueueSize();
 }
 
 
-TTYWrap::TTYWrap(Environment* env, Local<Object> object, int fd, bool readable)
+TTYWrap::TTYWrap(Environment* env,
+                 Local<Object> object,
+                 int fd,
+                 bool readable,
+                 int* init_err)
     : StreamWrap(env,
                  object,
                  reinterpret_cast<uv_stream_t*>(&handle_),
                  AsyncWrap::PROVIDER_TTYWRAP) {
-  uv_tty_init(env->event_loop(), &handle_, fd, readable);
+  *init_err = uv_tty_init(env->event_loop(), &handle_, fd, readable);
 }
 
 }  // namespace node