diff options
| author | C. Scott Ananian <cscott@cscott.net> | 2014-03-06 15:44:18 -0500 |
|---|---|---|
| committer | Trevor Norris <trev.norris@gmail.com> | 2014-04-02 01:48:34 -0700 |
| commit | 08a5b442e42ff67bd5666604eebe69f1b4a1c919 (patch) | |
| tree | ef08abc6ccc5fd1e07494b5074cf8b560c89f3cf /src/tty_wrap.cc | |
| parent | d4fcb23e38e74d21e04b3a17d10e52949b630ec0 (diff) | |
| download | android-node-v8-08a5b442e42ff67bd5666604eebe69f1b4a1c919.tar.gz android-node-v8-08a5b442e42ff67bd5666604eebe69f1b4a1c919.tar.bz2 android-node-v8-08a5b442e42ff67bd5666604eebe69f1b4a1c919.zip | |
node: add signature to SET_PROTOTYPE_METHOD
This prevents segfaults when a native method is reassigned to a
different object (which corrupts args.This()). When unwrapping,
clients should use args.Holder() instead of args.This().
Closes #6690.
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Diffstat (limited to 'src/tty_wrap.cc')
| -rw-r--r-- | src/tty_wrap.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/tty_wrap.cc b/src/tty_wrap.cc index a3957bea23..dba545b5f4 100644 --- a/src/tty_wrap.cc +++ b/src/tty_wrap.cc @@ -133,7 +133,7 @@ void TTYWrap::GetWindowSize(const FunctionCallbackInfo<Value>& args) { Environment* env = Environment::GetCurrent(args.GetIsolate()); HandleScope scope(env->isolate()); - TTYWrap* wrap = Unwrap<TTYWrap>(args.This()); + TTYWrap* wrap = Unwrap<TTYWrap>(args.Holder()); assert(args[0]->IsArray()); int width, height; @@ -153,7 +153,7 @@ void TTYWrap::SetRawMode(const FunctionCallbackInfo<Value>& args) { Environment* env = Environment::GetCurrent(args.GetIsolate()); HandleScope scope(env->isolate()); - TTYWrap* wrap = Unwrap<TTYWrap>(args.This()); + TTYWrap* wrap = Unwrap<TTYWrap>(args.Holder()); int err = uv_tty_set_mode(&wrap->handle_, args[0]->IsTrue()); args.GetReturnValue().Set(err); |