diff options
author | jeyanthinath <jeyanthinath10@gmail.com> | 2017-07-26 13:57:18 +0530 |
---|---|---|
committer | Timothy Gu <timothygu99@gmail.com> | 2017-08-07 10:16:30 +0800 |
commit | e88908d8684d4108a3079a6b6af0e5f4ce1b09b9 (patch) | |
tree | 88922a1406194d2833517bc85cc1ab0d3485ddbc /src/tracing/node_trace_writer.cc | |
parent | 5fd2f03b16bfd6730fe82dc3217f1d05131b9615 (diff) | |
download | android-node-v8-e88908d8684d4108a3079a6b6af0e5f4ce1b09b9.tar.gz android-node-v8-e88908d8684d4108a3079a6b6af0e5f4ce1b09b9.tar.bz2 android-node-v8-e88908d8684d4108a3079a6b6af0e5f4ce1b09b9.zip |
build: enable C++ linting for src/*/*
Fixes: https://github.com/nodejs/node/issues/14490
PR-URL: https://github.com/nodejs/node/pull/14497
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'src/tracing/node_trace_writer.cc')
-rw-r--r-- | src/tracing/node_trace_writer.cc | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/src/tracing/node_trace_writer.cc b/src/tracing/node_trace_writer.cc index 41753c5e65..ff3c981d10 100644 --- a/src/tracing/node_trace_writer.cc +++ b/src/tracing/node_trace_writer.cc @@ -27,7 +27,7 @@ void NodeTraceWriter::WriteSuffix() { { Mutex::ScopedLock scoped_lock(stream_mutex_); if (total_traces_ > 0) { - total_traces_ = 0; // so we don't write it again in FlushPrivate + total_traces_ = 0; // so we don't write it again in FlushPrivate // Appends "]}" to stream_. delete json_trace_writer_; should_flush = true; @@ -49,7 +49,7 @@ NodeTraceWriter::~NodeTraceWriter() { } uv_async_send(&exit_signal_); Mutex::ScopedLock scoped_lock(request_mutex_); - while(!exited_) { + while (!exited_) { exit_cond_.Wait(scoped_lock); } } @@ -110,8 +110,8 @@ void NodeTraceWriter::FlushSignalCb(uv_async_t* signal) { trace_writer->FlushPrivate(); } -// TODO: Remove (is it necessary to change the API? Since because of WriteSuffix -// it no longer matters whether it's true or false) +// TODO(matthewloring): Remove (is it necessary to change the API? +// Since because of WriteSuffix it no longer matters whether it's true or false) void NodeTraceWriter::Flush() { Flush(true); } @@ -172,9 +172,12 @@ void NodeTraceWriter::WriteCb(uv_fs_t* req) { // static void NodeTraceWriter::ExitSignalCb(uv_async_t* signal) { NodeTraceWriter* trace_writer = static_cast<NodeTraceWriter*>(signal->data); - uv_close(reinterpret_cast<uv_handle_t*>(&trace_writer->flush_signal_), nullptr); - uv_close(reinterpret_cast<uv_handle_t*>(&trace_writer->exit_signal_), [](uv_handle_t* signal) { - NodeTraceWriter* trace_writer = static_cast<NodeTraceWriter*>(signal->data); + uv_close(reinterpret_cast<uv_handle_t*>(&trace_writer->flush_signal_), + nullptr); + uv_close(reinterpret_cast<uv_handle_t*>(&trace_writer->exit_signal_), + [](uv_handle_t* signal) { + NodeTraceWriter* trace_writer = + static_cast<NodeTraceWriter*>(signal->data); Mutex::ScopedLock scoped_lock(trace_writer->request_mutex_); trace_writer->exited_ = true; trace_writer->exit_cond_.Signal(scoped_lock); |