diff options
author | Yaniv Friedensohn <yaniv.friedensohn@gmail.com> | 2019-05-11 20:00:38 +0300 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-08-09 15:58:58 -0700 |
commit | a0e2c6d2843ea6e37035a949827cdcc7949026d6 (patch) | |
tree | 8324272d3272db9c67a81d16c1dfd0e225069248 /src/string_bytes.h | |
parent | c065773cc56080b48ff4e29822152679f7db5573 (diff) | |
download | android-node-v8-a0e2c6d2843ea6e37035a949827cdcc7949026d6.tar.gz android-node-v8-a0e2c6d2843ea6e37035a949827cdcc7949026d6.tar.bz2 android-node-v8-a0e2c6d2843ea6e37035a949827cdcc7949026d6.zip |
src: add error codes to errors thrown in C++
PR-URL: https://github.com/nodejs/node/pull/27700
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'src/string_bytes.h')
-rw-r--r-- | src/string_bytes.h | 15 |
1 files changed, 1 insertions, 14 deletions
diff --git a/src/string_bytes.h b/src/string_bytes.h index 62a6724737..6ffdc47db7 100644 --- a/src/string_bytes.h +++ b/src/string_bytes.h @@ -37,14 +37,7 @@ class StringBytes { public: inline v8::Maybe<bool> Decode(Environment* env, v8::Local<v8::String> string, - v8::Local<v8::Value> encoding, - enum encoding _default) { - enum encoding enc = ParseEncoding(env->isolate(), encoding, _default); - if (!StringBytes::IsValidString(string, enc)) { - env->ThrowTypeError("Bad input string"); - return v8::Nothing<bool>(); - } - + enum encoding enc) { size_t storage; if (!StringBytes::StorageSize(env->isolate(), string, enc).To(&storage)) return v8::Nothing<bool>(); @@ -60,12 +53,6 @@ class StringBytes { inline size_t size() const { return length(); } }; - // Does the string match the encoding? Quick but non-exhaustive. - // Example: a HEX string must have a length that's a multiple of two. - // FIXME(bnoordhuis) IsMaybeValidString()? Naming things is hard... - static bool IsValidString(v8::Local<v8::String> string, - enum encoding enc); - // Fast, but can be 2 bytes oversized for Base64, and // as much as triple UTF-8 strings <= 65536 chars in length static v8::Maybe<size_t> StorageSize(v8::Isolate* isolate, |