diff options
author | isaacs <i@izs.me> | 2012-04-12 16:03:47 -0700 |
---|---|---|
committer | isaacs <i@izs.me> | 2012-04-17 13:14:54 -0700 |
commit | a26bee8fa16bcbdaafdee516288c6f59a43376f5 (patch) | |
tree | 33bdf31ce9891151c4d77ef785b86efb843b3d9e /src/stream_wrap.cc | |
parent | db45b2ca02dc23278a477625a8698ce136eb8807 (diff) | |
download | android-node-v8-a26bee8fa16bcbdaafdee516288c6f59a43376f5.tar.gz android-node-v8-a26bee8fa16bcbdaafdee516288c6f59a43376f5.tar.bz2 android-node-v8-a26bee8fa16bcbdaafdee516288c6f59a43376f5.zip |
MakeCallback: Consistent symbol usage
Diffstat (limited to 'src/stream_wrap.cc')
-rw-r--r-- | src/stream_wrap.cc | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/src/stream_wrap.cc b/src/stream_wrap.cc index 234aa3dc2f..9fcb5b1b95 100644 --- a/src/stream_wrap.cc +++ b/src/stream_wrap.cc @@ -69,6 +69,8 @@ typedef class ReqWrap<uv_write_t> WriteWrap; static Persistent<String> buffer_sym; static Persistent<String> write_queue_size_sym; +static Persistent<String> onread_sym; +static Persistent<String> oncomplete_sym; static SlabAllocator slab_allocator(SLAB_SIZE); static bool initialized; @@ -81,9 +83,10 @@ void StreamWrap::Initialize(Handle<Object> target) { HandleWrap::Initialize(target); - buffer_sym = Persistent<String>::New(String::NewSymbol("buffer")); - write_queue_size_sym = - Persistent<String>::New(String::NewSymbol("writeQueueSize")); + buffer_sym = NODE_PSYMBOL("buffer"); + write_queue_size_sym = NODE_PSYMBOL("writeQueueSize"); + onread_sym = NODE_PSYMBOL("onread"); + oncomplete_sym = NODE_PSYMBOL("oncomplete"); } @@ -170,7 +173,7 @@ void StreamWrap::OnReadCommon(uv_stream_t* handle, ssize_t nread, } SetErrno(uv_last_error(uv_default_loop())); - MakeCallback(wrap->object_, "onread", 0, NULL); + MakeCallback(wrap->object_, onread_sym, 0, NULL); return; } @@ -208,7 +211,7 @@ void StreamWrap::OnReadCommon(uv_stream_t* handle, ssize_t nread, argc++; } - MakeCallback(wrap->object_, "onread", argc, argv); + MakeCallback(wrap->object_, onread_sym, argc, argv); } @@ -313,7 +316,7 @@ void StreamWrap::AfterWrite(uv_write_t* req, int status) { req_wrap->object_->GetHiddenValue(buffer_sym), }; - MakeCallback(req_wrap->object_, "oncomplete", 4, argv); + MakeCallback(req_wrap->object_, oncomplete_sym, ARRAY_SIZE(argv), argv); delete req_wrap; } @@ -360,7 +363,7 @@ void StreamWrap::AfterShutdown(uv_shutdown_t* req, int status) { Local<Value>::New(req_wrap->object_) }; - MakeCallback(req_wrap->object_, "oncomplete", 3, argv); + MakeCallback(req_wrap->object_, oncomplete_sym, ARRAY_SIZE(argv), argv); delete req_wrap; } |