diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-03-24 23:12:22 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-05-10 14:15:18 +0200 |
| commit | 2b3150466e5f4db841f5980cda32172555bdda15 (patch) | |
| tree | fd68fdd08feb9681f5ab05d5716f484acb9d796a /src/stream_wrap.cc | |
| parent | 5d7045960628084f79f5da74272000b7d0b8256f (diff) | |
| download | android-node-v8-2b3150466e5f4db841f5980cda32172555bdda15.tar.gz android-node-v8-2b3150466e5f4db841f5980cda32172555bdda15.tar.bz2 android-node-v8-2b3150466e5f4db841f5980cda32172555bdda15.zip | |
src: always call ReadStop() before Close()
For libuv-backed streams, always explicitly stop reading before
closing the handle.
PR-URL: https://github.com/nodejs/node/pull/19377
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/stream_wrap.cc')
| -rw-r--r-- | src/stream_wrap.cc | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/stream_wrap.cc b/src/stream_wrap.cc index 0e700ba39a..cdcbe574f9 100644 --- a/src/stream_wrap.cc +++ b/src/stream_wrap.cc @@ -373,6 +373,11 @@ void LibuvStreamWrap::AfterUvWrite(uv_write_t* req, int status) { req_wrap->Done(status); } +void LibuvStreamWrap::Close(v8::Local<v8::Value> close_callback) { + ReadStop(); + HandleWrap::Close(close_callback); +} + } // namespace node NODE_BUILTIN_MODULE_CONTEXT_AWARE(stream_wrap, |