diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-07-22 09:12:19 +0800 |
---|---|---|
committer | Joyee Cheung <joyeec9h3@gmail.com> | 2018-07-27 15:51:19 +0800 |
commit | 28a3e280eca67f906ae3b47730fe21a389b7bccb (patch) | |
tree | 18a051e45196e6d8a677dd9122470d285e3e34aa /src/stream_base.h | |
parent | 48e5b350b3dd236353e3e8e1196a09f5c5bcda77 (diff) | |
download | android-node-v8-28a3e280eca67f906ae3b47730fe21a389b7bccb.tar.gz android-node-v8-28a3e280eca67f906ae3b47730fe21a389b7bccb.tar.bz2 android-node-v8-28a3e280eca67f906ae3b47730fe21a389b7bccb.zip |
src: add proper MemoryInfoName to wrappers
- Use camel case names for memory retainers inherited from AsyncWrap
instead of their provider names (which are all in upper case)
- Assign class names to wraps so that they appear in the heap snapshot
as nodes with class names as node names. Previously some nodes are
named with reference names, which are supposed to be edge names
instead.
PR-URL: https://github.com/nodejs/node/pull/21939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Diffstat (limited to 'src/stream_base.h')
-rw-r--r-- | src/stream_base.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/stream_base.h b/src/stream_base.h index bbb20e52e1..05c2a96236 100644 --- a/src/stream_base.h +++ b/src/stream_base.h @@ -350,6 +350,8 @@ class SimpleShutdownWrap : public ShutdownWrap, public OtherBase { void MemoryInfo(MemoryTracker* tracker) const override { tracker->TrackThis(this); } + + ADD_MEMORY_INFO_NAME(SimpleShutdownWrap) }; template <typename OtherBase> @@ -364,6 +366,9 @@ class SimpleWriteWrap : public WriteWrap, public OtherBase { tracker->TrackThis(this); tracker->TrackFieldWithSize("storage", StorageSize()); } + + + ADD_MEMORY_INFO_NAME(SimpleWriteWrap) }; } // namespace node |