diff options
| author | Anna Henningsen <anna@addaleax.net> | 2017-11-03 20:13:18 +0100 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2017-11-03 14:46:28 -0700 |
| commit | a5f3b3a6dab18e32ee5e7d0d79a63cec0d5d5cc5 (patch) | |
| tree | be72fa320672dca39459a2fb957e973a6fc06f0b /src/stream_base-inl.h | |
| parent | 5d0436fbeafeb0498d82430d38650b65a5c4220d (diff) | |
| download | android-node-v8-a5f3b3a6dab18e32ee5e7d0d79a63cec0d5d5cc5.tar.gz android-node-v8-a5f3b3a6dab18e32ee5e7d0d79a63cec0d5d5cc5.tar.bz2 android-node-v8-a5f3b3a6dab18e32ee5e7d0d79a63cec0d5d5cc5.zip | |
src: add method to compute storage in WriteWrap
`WriteWrap` instances may contain extra storage space.
`self_size()` returns the size of the *entire* struct, member fields as
well as storage space, so it is not an accurate measure for the
storage space available.
Add a method `ExtraSize()` (like the existing `Extra()` for accessing
the storage memory) that yields the wanted value, and use it
in the HTTP2 impl to fix a crash.
PR-URL: https://github.com/nodejs/node/pull/16727
Refs: https://github.com/nodejs/node/pull/16669
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/stream_base-inl.h')
| -rw-r--r-- | src/stream_base-inl.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/stream_base-inl.h b/src/stream_base-inl.h index 667c0a9ffb..e1e50802f2 100644 --- a/src/stream_base-inl.h +++ b/src/stream_base-inl.h @@ -160,6 +160,10 @@ char* WriteWrap::Extra(size_t offset) { offset; } +size_t WriteWrap::ExtraSize() const { + return storage_size_ - ROUND_UP(sizeof(*this), kAlignSize); +} + } // namespace node #endif // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS |