diff options
| author | Ujjwal Sharma <usharma1998@gmail.com> | 2018-08-29 15:39:55 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-09-02 14:25:16 +0200 |
| commit | a55c57b8c48d4d09d3fb74ffddab6e87d10f2030 (patch) | |
| tree | abfb494acec7b5bdc1e817a2f9de4a3cb9c11de7 /src/spawn_sync.h | |
| parent | 67403b3a849f86ccd03bcf3b829a89d74471f9ca (diff) | |
| download | android-node-v8-a55c57b8c48d4d09d3fb74ffddab6e87d10f2030.tar.gz android-node-v8-a55c57b8c48d4d09d3fb74ffddab6e87d10f2030.tar.bz2 android-node-v8-a55c57b8c48d4d09d3fb74ffddab6e87d10f2030.zip | |
src: rework (mostly internal) functions to use Maybes
Rework all affected functions to use Maybes, thus improving error
handling substantially in internal functions, API functions as well as
utilities.
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/21935
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'src/spawn_sync.h')
| -rw-r--r-- | src/spawn_sync.h | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/src/spawn_sync.h b/src/spawn_sync.h index fed1453296..adb2618cc5 100644 --- a/src/spawn_sync.h +++ b/src/spawn_sync.h @@ -152,8 +152,8 @@ class SyncProcessRunner { inline Environment* env() const; - v8::Local<v8::Object> Run(v8::Local<v8::Value> options); - void TryInitializeAndRunLoop(v8::Local<v8::Value> options); + v8::MaybeLocal<v8::Object> Run(v8::Local<v8::Value> options); + v8::Maybe<bool> TryInitializeAndRunLoop(v8::Local<v8::Value> options); void CloseHandlesAndDeleteLoop(); void CloseStdioPipes(); @@ -172,7 +172,7 @@ class SyncProcessRunner { v8::Local<v8::Object> BuildResultObject(); v8::Local<v8::Array> BuildOutputArray(); - int ParseOptions(v8::Local<v8::Value> js_value); + v8::Maybe<int> ParseOptions(v8::Local<v8::Value> js_value); int ParseStdioOptions(v8::Local<v8::Value> js_value); int ParseStdioOption(int child_fd, v8::Local<v8::Object> js_stdio_option); @@ -184,8 +184,10 @@ class SyncProcessRunner { inline int AddStdioInheritFD(uint32_t child_fd, int inherit_fd); static bool IsSet(v8::Local<v8::Value> value); - int CopyJsString(v8::Local<v8::Value> js_value, const char** target); - int CopyJsStringArray(v8::Local<v8::Value> js_value, char** target); + v8::Maybe<int> CopyJsString(v8::Local<v8::Value> js_value, + const char** target); + v8::Maybe<int> CopyJsStringArray(v8::Local<v8::Value> js_value, + char** target); static void ExitCallback(uv_process_t* handle, int64_t exit_status, |