diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2014-10-11 16:24:12 +0200 |
|---|---|---|
| committer | Fedor Indutny <fedor@indutny.com> | 2014-10-12 02:09:16 +0400 |
| commit | 97585b0d7ab0084d90faf6bded275b902d76857a (patch) | |
| tree | 26853d875786c014e2e9ef5ed2ec18f7ed601775 /src/spawn_sync.cc | |
| parent | b2e519983f1e92a874a74c11e82027955ef8909a (diff) | |
| download | android-node-v8-97585b0d7ab0084d90faf6bded275b902d76857a.tar.gz android-node-v8-97585b0d7ab0084d90faf6bded275b902d76857a.tar.bz2 android-node-v8-97585b0d7ab0084d90faf6bded275b902d76857a.zip | |
src: remove unnecessary HandleScopes
API callback functions don't need to create a v8::HandleScope instance
because V8 already creates one in the JS->C++ adapter frame.
PR-URL: https://github.com/node-forward/node/pull/16
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Diffstat (limited to 'src/spawn_sync.cc')
| -rw-r--r-- | src/spawn_sync.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc index 59de8d4630..67ec98ba03 100644 --- a/src/spawn_sync.cc +++ b/src/spawn_sync.cc @@ -362,7 +362,6 @@ void SyncProcessRunner::Initialize(Handle<Object> target, void SyncProcessRunner::Spawn(const FunctionCallbackInfo<Value>& args) { Isolate* isolate = args.GetIsolate(); - HandleScope scope(isolate); SyncProcessRunner p(Environment::GetCurrent(isolate)); Local<Value> result = p.Run(args[0]); args.GetReturnValue().Set(result); |