diff options
| author | João Reis <reis@janeasystems.com> | 2015-09-23 13:33:09 +0100 |
|---|---|---|
| committer | João Reis <reis@janeasystems.com> | 2015-10-01 11:50:51 +0100 |
| commit | a6aab430936c4c2791dbb29d8adec9d9a12f9376 (patch) | |
| tree | a455d76672ed183bd19f681fa15f0cd5409106cb /src/res | |
| parent | d32363ff2049a5d6f53d3e9ce7255c474838a6d5 (diff) | |
| download | android-node-v8-a6aab430936c4c2791dbb29d8adec9d9a12f9376.tar.gz android-node-v8-a6aab430936c4c2791dbb29d8adec9d9a12f9376.tar.bz2 android-node-v8-a6aab430936c4c2791dbb29d8adec9d9a12f9376.zip | |
build,win: fix node.exe resource version
When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but
passes it correctly to cl.exe. Hence, this workaround was made to
apply only to the resource file.
Fixes: https://github.com/nodejs/node/issues/2963
PR-URL: https://github.com/nodejs/node/pull/3053
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Diffstat (limited to 'src/res')
| -rw-r--r-- | src/res/node.rc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/res/node.rc b/src/res/node.rc index 587843df2f..b2f7f3029f 100644 --- a/src/res/node.rc +++ b/src/res/node.rc @@ -32,8 +32,8 @@ BEGIN VALUE "CompanyName", "Node.js" VALUE "ProductName", "Node.js" VALUE "FileDescription", "Node.js: Server-side JavaScript" - VALUE "FileVersion", "NODE_VERSION_STRING" - VALUE "ProductVersion", "NODE_VERSION_STRING" + VALUE "FileVersion", NODE_EXE_VERSION + VALUE "ProductVersion", NODE_EXE_VERSION VALUE "OriginalFilename", "node.exe" VALUE "InternalName", "node" VALUE "LegalCopyright", "Copyright Node.js contributors. MIT license." |