diff options
| author | Bert Belder <bertbelder@gmail.com> | 2013-08-25 18:44:57 +0200 |
|---|---|---|
| committer | Bert Belder <bertbelder@gmail.com> | 2013-08-25 18:45:38 +0200 |
| commit | 87405b0d98e5f96eec1bd3ddfea6fe4ad2489892 (patch) | |
| tree | 3299e242789b2b643a9276a9f099e02be063f823 /src/process_wrap.cc | |
| parent | 833385973521654629a38065c6c6ca9d45c201da (diff) | |
| download | android-node-v8-87405b0d98e5f96eec1bd3ddfea6fe4ad2489892.tar.gz android-node-v8-87405b0d98e5f96eec1bd3ddfea6fe4ad2489892.tar.bz2 android-node-v8-87405b0d98e5f96eec1bd3ddfea6fe4ad2489892.zip | |
process_wrap: don't coerce process exit code to int32_t
On windows process exit codes can be greater than INT32_MAX. This used
to be not much of a problem - greater values would just come out
negative. However since ca9eb71 a negative result value indicates that
uv_spawn() has failed, so this is no longer acceptable.
Diffstat (limited to 'src/process_wrap.cc')
| -rw-r--r-- | src/process_wrap.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/process_wrap.cc b/src/process_wrap.cc index 2dbfdfb30f..aebed822e7 100644 --- a/src/process_wrap.cc +++ b/src/process_wrap.cc @@ -275,7 +275,7 @@ class ProcessWrap : public HandleWrap { assert(&wrap->process_ == handle); Local<Value> argv[] = { - Integer::New(exit_status, node_isolate), + Number::New(node_isolate, static_cast<double>(exit_status)), OneByteString(node_isolate, signo_string(term_signal)) }; |