diff options
author | Trevor Norris <trev.norris@gmail.com> | 2014-12-09 05:02:09 +0100 |
---|---|---|
committer | Bert Belder <bertbelder@gmail.com> | 2014-12-09 17:57:17 +0100 |
commit | bd83c3966d4564709e8449b3c699af6ece27ff12 (patch) | |
tree | 69be93abab35fb0ad8f5e13bfd28c89244488139 /src/pipe_wrap.h | |
parent | afe27e34cfc46e86334e2c17b6cbeb0afa316fff (diff) | |
download | android-node-v8-bd83c3966d4564709e8449b3c699af6ece27ff12.tar.gz android-node-v8-bd83c3966d4564709e8449b3c699af6ece27ff12.tar.bz2 android-node-v8-bd83c3966d4564709e8449b3c699af6ece27ff12.zip |
async-wrap: explicitly pass parent
When instantiating a new AsyncWrap allow the parent AsyncWrap to be
passed. This is useful for cases like TCP incoming connections, so the
connection can be tied to the server receiving the connection.
Because the current architecture instantiates the *Wrap inside a
v8::FunctionCallback, the parent pointer is currently wrapped inside a
new v8::External every time and passed as an argument. This adds ~80ns
to instantiation time.
A future optimization would be to add the v8::External as the data field
when creating the v8::FunctionTemplate, change the pointer just before
making the call then NULL'ing it out afterwards. This adds enough code
complexity that it will not be attempted until the current approach
demonstrates it is a bottle neck.
PR-URL: https://github.com/joyent/node/pull/8110
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Fedor Indutny <fedor@indutny.com>
Reviewed-by: Alexis Campailla <alexis@janeasystems.com>
Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Diffstat (limited to 'src/pipe_wrap.h')
-rw-r--r-- | src/pipe_wrap.h | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/pipe_wrap.h b/src/pipe_wrap.h index 92492c42b7..959f28f4dc 100644 --- a/src/pipe_wrap.h +++ b/src/pipe_wrap.h @@ -22,6 +22,7 @@ #ifndef SRC_PIPE_WRAP_H_ #define SRC_PIPE_WRAP_H_ +#include "async-wrap.h" #include "env.h" #include "stream_wrap.h" @@ -31,13 +32,16 @@ class PipeWrap : public StreamWrap { public: uv_pipe_t* UVHandle(); - static v8::Local<v8::Object> Instantiate(Environment* env); + static v8::Local<v8::Object> Instantiate(Environment* env, AsyncWrap* parent); static void Initialize(v8::Handle<v8::Object> target, v8::Handle<v8::Value> unused, v8::Handle<v8::Context> context); private: - PipeWrap(Environment* env, v8::Handle<v8::Object> object, bool ipc); + PipeWrap(Environment* env, + v8::Handle<v8::Object> object, + bool ipc, + AsyncWrap* parent); static void New(const v8::FunctionCallbackInfo<v8::Value>& args); static void Bind(const v8::FunctionCallbackInfo<v8::Value>& args); |