diff options
author | Ben Noordhuis <info@bnoordhuis.nl> | 2014-10-13 15:19:55 +0200 |
---|---|---|
committer | Fedor Indutny <fedor@indutny.com> | 2014-10-13 23:46:46 +0400 |
commit | d3c317e08ac6a624fde8b242905992eafdd954ac (patch) | |
tree | 1dd2756855ab5b4513503acc660705fa898c5c64 /src/pipe_wrap.cc | |
parent | b45d33617b569bf5fa84c9343da9f7d129756968 (diff) | |
download | android-node-v8-d3c317e08ac6a624fde8b242905992eafdd954ac.tar.gz android-node-v8-d3c317e08ac6a624fde8b242905992eafdd954ac.tar.bz2 android-node-v8-d3c317e08ac6a624fde8b242905992eafdd954ac.zip |
src: attach env directly to api functions
Attach the per-context execution environment directly to API functions.
Rationale:
* Gets node one step closer to multi-isolate readiness.
* Avoids multi-context confusion, e.g. when the caller and callee live
in different contexts.
* Avoids expensive calls to pthread_getspecific() on platforms where
V8 does not know how to use the thread-local storage directly.
(Linux, the BSDs.)
PR-URL: https://github.com/node-forward/node/pull/18
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Diffstat (limited to 'src/pipe_wrap.cc')
-rw-r--r-- | src/pipe_wrap.cc | 46 |
1 files changed, 21 insertions, 25 deletions
diff --git a/src/pipe_wrap.cc b/src/pipe_wrap.cc index 7bcc0fb155..65f16d64d0 100644 --- a/src/pipe_wrap.cc +++ b/src/pipe_wrap.cc @@ -75,7 +75,7 @@ void PipeWrap::Initialize(Handle<Object> target, Handle<Context> context) { Environment* env = Environment::GetCurrent(context); - Local<FunctionTemplate> t = FunctionTemplate::New(env->isolate(), New); + Local<FunctionTemplate> t = env->NewFunctionTemplate(New); t->SetClassName(FIXED_ONE_BYTE_STRING(env->isolate(), "Pipe")); t->InstanceTemplate()->SetInternalFieldCount(1); @@ -88,33 +88,29 @@ void PipeWrap::Initialize(Handle<Object> target, v8::DEFAULT, attributes); - NODE_SET_PROTOTYPE_METHOD(t, "close", HandleWrap::Close); - NODE_SET_PROTOTYPE_METHOD(t, "unref", HandleWrap::Unref); - NODE_SET_PROTOTYPE_METHOD(t, "ref", HandleWrap::Ref); + env->SetProtoMethod(t, "close", HandleWrap::Close); + env->SetProtoMethod(t, "unref", HandleWrap::Unref); + env->SetProtoMethod(t, "ref", HandleWrap::Ref); - NODE_SET_PROTOTYPE_METHOD(t, "setBlocking", StreamWrap::SetBlocking); + env->SetProtoMethod(t, "setBlocking", StreamWrap::SetBlocking); - NODE_SET_PROTOTYPE_METHOD(t, "readStart", StreamWrap::ReadStart); - NODE_SET_PROTOTYPE_METHOD(t, "readStop", StreamWrap::ReadStop); - NODE_SET_PROTOTYPE_METHOD(t, "shutdown", StreamWrap::Shutdown); + env->SetProtoMethod(t, "readStart", StreamWrap::ReadStart); + env->SetProtoMethod(t, "readStop", StreamWrap::ReadStop); + env->SetProtoMethod(t, "shutdown", StreamWrap::Shutdown); - NODE_SET_PROTOTYPE_METHOD(t, "writeBuffer", StreamWrap::WriteBuffer); - NODE_SET_PROTOTYPE_METHOD(t, - "writeAsciiString", - StreamWrap::WriteAsciiString); - NODE_SET_PROTOTYPE_METHOD(t, "writeUtf8String", StreamWrap::WriteUtf8String); - NODE_SET_PROTOTYPE_METHOD(t, "writeUcs2String", StreamWrap::WriteUcs2String); - NODE_SET_PROTOTYPE_METHOD(t, - "writeBinaryString", - StreamWrap::WriteBinaryString); + env->SetProtoMethod(t, "writeBuffer", StreamWrap::WriteBuffer); + env->SetProtoMethod(t, "writeAsciiString", StreamWrap::WriteAsciiString); + env->SetProtoMethod(t, "writeUtf8String", StreamWrap::WriteUtf8String); + env->SetProtoMethod(t, "writeUcs2String", StreamWrap::WriteUcs2String); + env->SetProtoMethod(t, "writeBinaryString", StreamWrap::WriteBinaryString); - NODE_SET_PROTOTYPE_METHOD(t, "bind", Bind); - NODE_SET_PROTOTYPE_METHOD(t, "listen", Listen); - NODE_SET_PROTOTYPE_METHOD(t, "connect", Connect); - NODE_SET_PROTOTYPE_METHOD(t, "open", Open); + env->SetProtoMethod(t, "bind", Bind); + env->SetProtoMethod(t, "listen", Listen); + env->SetProtoMethod(t, "connect", Connect); + env->SetProtoMethod(t, "open", Open); #ifdef _WIN32 - NODE_SET_PROTOTYPE_METHOD(t, "setPendingInstances", SetPendingInstances); + env->SetProtoMethod(t, "setPendingInstances", SetPendingInstances); #endif target->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "Pipe"), t->GetFunction()); @@ -127,7 +123,7 @@ void PipeWrap::New(const FunctionCallbackInfo<Value>& args) { // Therefore we assert that we are not trying to call this as a // normal function. CHECK(args.IsConstructCall()); - Environment* env = Environment::GetCurrent(args.GetIsolate()); + Environment* env = Environment::GetCurrent(args); new PipeWrap(env, args.This(), args[0]->IsTrue()); } @@ -247,7 +243,7 @@ void PipeWrap::AfterConnect(uv_connect_t* req, int status) { void PipeWrap::Open(const FunctionCallbackInfo<Value>& args) { - Environment* env = Environment::GetCurrent(args.GetIsolate()); + Environment* env = Environment::GetCurrent(args); PipeWrap* wrap = Unwrap<PipeWrap>(args.Holder()); @@ -261,7 +257,7 @@ void PipeWrap::Open(const FunctionCallbackInfo<Value>& args) { void PipeWrap::Connect(const FunctionCallbackInfo<Value>& args) { - Environment* env = Environment::GetCurrent(args.GetIsolate()); + Environment* env = Environment::GetCurrent(args); PipeWrap* wrap = Unwrap<PipeWrap>(args.Holder()); |