diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-03-17 22:34:38 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-05-10 14:15:17 +0200 |
| commit | 63a84609fb24b245838f2d0838d5141d36f09f83 (patch) | |
| tree | ff305d954ab9faf7f37f2b7a64ac41a715882c82 /src/pipe_wrap.cc | |
| parent | a928b2d5300ff5a4d6223c59c4e3bda818de5113 (diff) | |
| download | android-node-v8-63a84609fb24b245838f2d0838d5141d36f09f83.tar.gz android-node-v8-63a84609fb24b245838f2d0838d5141d36f09f83.tar.bz2 android-node-v8-63a84609fb24b245838f2d0838d5141d36f09f83.zip | |
src: store fd for libuv streams on Windows
On Windows, we can't just look up a FD for libuv streams and
return it in `GetFD()`.
However, we do sometimes construct streams from their FDs;
in those cases, it should be okay to store the value on a class field.
PR-URL: https://github.com/nodejs/node/pull/19377
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/pipe_wrap.cc')
| -rw-r--r-- | src/pipe_wrap.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/pipe_wrap.cc b/src/pipe_wrap.cc index 7ec5bdf15b..f3a88a2ecc 100644 --- a/src/pipe_wrap.cc +++ b/src/pipe_wrap.cc @@ -204,6 +204,7 @@ void PipeWrap::Open(const FunctionCallbackInfo<Value>& args) { int fd = args[0]->Int32Value(); int err = uv_pipe_open(&wrap->handle_, fd); + wrap->set_fd(fd); if (err != 0) env->isolate()->ThrowException(UVException(err, "uv_pipe_open")); |