summaryrefslogtreecommitdiff
path: root/src/pipe_wrap.cc
diff options
context:
space:
mode:
authorSam Roberts <vieuxtech@gmail.com>2019-04-09 15:21:36 -0700
committerSam Roberts <vieuxtech@gmail.com>2019-04-12 12:33:37 -0700
commit060d901f87b3d87314f8540eb02f315e2952f581 (patch)
tree53159171201703bb6d8a4e780c8624a5c6c8cbb5 /src/pipe_wrap.cc
parent7b0d8673898e65a368108264c77bccaa3e004028 (diff)
downloadandroid-node-v8-060d901f87b3d87314f8540eb02f315e2952f581.tar.gz
android-node-v8-060d901f87b3d87314f8540eb02f315e2952f581.tar.bz2
android-node-v8-060d901f87b3d87314f8540eb02f315e2952f581.zip
src: replace FromJust() with Check() when possible
FromJust() is often used not for its return value, but for its side-effects. In these cases, Check() exists, and is more clear as to the intent. From its comment: To be used, where the actual value of the Maybe is not needed, like Object::Set. See: https://github.com/nodejs/node/pull/26929/files#r269256335 PR-URL: https://github.com/nodejs/node/pull/27162 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Diffstat (limited to 'src/pipe_wrap.cc')
-rw-r--r--src/pipe_wrap.cc6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/pipe_wrap.cc b/src/pipe_wrap.cc
index cafa33f9af..26ccfd8a47 100644
--- a/src/pipe_wrap.cc
+++ b/src/pipe_wrap.cc
@@ -90,7 +90,7 @@ void PipeWrap::Initialize(Local<Object> target,
target->Set(env->context(),
pipeString,
- t->GetFunction(env->context()).ToLocalChecked()).FromJust();
+ t->GetFunction(env->context()).ToLocalChecked()).Check();
env->set_pipe_constructor_template(t);
// Create FunctionTemplate for PipeConnectWrap.
@@ -101,7 +101,7 @@ void PipeWrap::Initialize(Local<Object> target,
cwt->SetClassName(wrapString);
target->Set(env->context(),
wrapString,
- cwt->GetFunction(env->context()).ToLocalChecked()).FromJust();
+ cwt->GetFunction(env->context()).ToLocalChecked()).Check();
// Define constants
Local<Object> constants = Object::New(env->isolate());
@@ -112,7 +112,7 @@ void PipeWrap::Initialize(Local<Object> target,
NODE_DEFINE_CONSTANT(constants, UV_WRITABLE);
target->Set(context,
env->constants_string(),
- constants).FromJust();
+ constants).Check();
}