summaryrefslogtreecommitdiff
path: root/src/node_worker.h
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2019-10-22 22:03:53 +0200
committerMichaƫl Zasso <targos@protonmail.com>2019-11-08 15:53:36 +0100
commit2bdeb88c27b4d8de3a8f6b7a438cf0bcb88fa927 (patch)
treec86c4faa4410216460c25053ab22061ee3f9897f /src/node_worker.h
parent2707efd27b5ce5f9b9a6873438769394ef1c6431 (diff)
downloadandroid-node-v8-2bdeb88c27b4d8de3a8f6b7a438cf0bcb88fa927.tar.gz
android-node-v8-2bdeb88c27b4d8de3a8f6b7a438cf0bcb88fa927.tar.bz2
android-node-v8-2bdeb88c27b4d8de3a8f6b7a438cf0bcb88fa927.zip
src: remove custom tracking for SharedArrayBuffers
Remove custom tracking for `SharedArrayBuffer`s and their allocators and instead let V8 do the tracking of both. This is required starting in V8 7.9, because lifetime management for `ArrayBuffer::Allocator`s differs from what was performed previously (i.e. it is no longer easily possible for one Isolate to release an `ArrayBuffer` and another to accept it into its own allocator), and the alternative would have been adapting the `SharedArrayBuffer` tracking logic to also apply to regular `ArrayBuffer` instances. Refs: https://github.com/nodejs/node/pull/30044 PR-URL: https://github.com/nodejs/node/pull/30020 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'src/node_worker.h')
-rw-r--r--src/node_worker.h2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/node_worker.h b/src/node_worker.h
index 46eab70a49..7b1311734a 100644
--- a/src/node_worker.h
+++ b/src/node_worker.h
@@ -48,7 +48,6 @@ class Worker : public AsyncWrap {
SET_SELF_SIZE(Worker)
bool is_stopped() const;
- std::shared_ptr<ArrayBufferAllocator> array_buffer_allocator();
static void New(const v8::FunctionCallbackInfo<v8::Value>& args);
static void CloneParentEnvVars(
@@ -72,7 +71,6 @@ class Worker : public AsyncWrap {
std::vector<std::string> argv_;
MultiIsolatePlatform* platform_;
- std::shared_ptr<ArrayBufferAllocator> array_buffer_allocator_;
v8::Isolate* isolate_ = nullptr;
bool start_profiler_idle_notifier_;
uv_thread_t tid_;