diff options
| author | Refael Ackermann <refack@gmail.com> | 2019-02-25 15:42:28 -0500 |
|---|---|---|
| committer | Refael Ackermann <refack@gmail.com> | 2019-03-03 20:03:31 -0500 |
| commit | 2c6d94f3db89ed4dfa3e68e7e945c10e3662ea41 (patch) | |
| tree | 2ef84cb998275f475d1812f94ca9a59cbeacd583 /src/node_worker.cc | |
| parent | af8b92c0731603e5337cca3202603402d345c0a9 (diff) | |
| download | android-node-v8-2c6d94f3db89ed4dfa3e68e7e945c10e3662ea41.tar.gz android-node-v8-2c6d94f3db89ed4dfa3e68e7e945c10e3662ea41.tar.bz2 android-node-v8-2c6d94f3db89ed4dfa3e68e7e945c10e3662ea41.zip | |
src: fix warnings around node_options
* header explicit usage, order, and reduce use of `*-inl.h`
* pointer -> const reference when possible
* no variable recyclicng
* `std::begin/end` prefered over `instance.begin/end`
* `USE` for explicit unused resaults
PR-URL: https://github.com/nodejs/node/pull/26280
Fixes: https://github.com/nodejs/node/issues/25593
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'src/node_worker.cc')
| -rw-r--r-- | src/node_worker.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node_worker.cc b/src/node_worker.cc index e22503863d..5ab4fad5d4 100644 --- a/src/node_worker.cc +++ b/src/node_worker.cc @@ -487,13 +487,13 @@ void Worker::New(const FunctionCallbackInfo<Value>& args) { // The first argument is program name. invalid_args.erase(invalid_args.begin()); if (errors.size() > 0 || invalid_args.size() > 0) { - v8::Local<v8::Value> value = + v8::Local<v8::Value> error = ToV8Value(env->context(), errors.size() > 0 ? errors : invalid_args) .ToLocalChecked(); Local<String> key = FIXED_ONE_BYTE_STRING(env->isolate(), "invalidExecArgv"); - args.This()->Set(env->context(), key, value).FromJust(); + USE(args.This()->Set(env->context(), key, error).FromJust()); return; } } |