diff options
| author | Gus Caplan <me@gus.host> | 2019-04-15 16:09:51 -0500 |
|---|---|---|
| committer | Sam Roberts <vieuxtech@gmail.com> | 2019-05-16 10:52:53 -0700 |
| commit | f2061930c83cb579410a7f26bed726d6568575e3 (patch) | |
| tree | ddcfcc116344fd03d5d04721df49eacb0059dd13 /src/node_watchdog.h | |
| parent | cca375f4af235ed7e7f763b2e35532ae843a5854 (diff) | |
| download | android-node-v8-f2061930c83cb579410a7f26bed726d6568575e3.tar.gz android-node-v8-f2061930c83cb579410a7f26bed726d6568575e3.tar.bz2 android-node-v8-f2061930c83cb579410a7f26bed726d6568575e3.zip | |
src: enable V8's WASM trap handlers
This uses SIGSEGV handlers to catch WASM out of bound (OOB) memory
accesses instead of inserting OOB checks inline, resulting in a 25%-30%
speed increase.
Note that installing a custom SIGSEGV handler will break this, resulting
in potentially scary behaviour.
Refs: https://github.com/nodejs/node/issues/14927
PR-URL: https://github.com/nodejs/node/pull/27246
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'src/node_watchdog.h')
| -rw-r--r-- | src/node_watchdog.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_watchdog.h b/src/node_watchdog.h index 9c56b90e9e..36c2df1109 100644 --- a/src/node_watchdog.h +++ b/src/node_watchdog.h @@ -99,7 +99,7 @@ class SigintWatchdogHelper { bool stopping_; static void* RunSigintWatchdog(void* arg); - static void HandleSignal(int signum); + static void HandleSignal(int signum, siginfo_t* info, void* ucontext); #else bool watchdog_disabled_; static BOOL WINAPI WinCtrlCHandlerRoutine(DWORD dwCtrlType); |