diff options
| author | Sam Roberts <vieuxtech@gmail.com> | 2016-12-22 10:31:36 -0800 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2016-12-27 13:38:43 -0800 |
| commit | 1257546a41991dbf1b613668fc5d00f7605b4112 (patch) | |
| tree | 2a0f9304de0061cb6770940da07f9a521fc1f8b5 /src/node_version.h | |
| parent | 0dc09eb7465686cf26a16353abc707c1bbd92d55 (diff) | |
| download | android-node-v8-1257546a41991dbf1b613668fc5d00f7605b4112.tar.gz android-node-v8-1257546a41991dbf1b613668fc5d00f7605b4112.tar.bz2 android-node-v8-1257546a41991dbf1b613668fc5d00f7605b4112.zip | |
src: describe what NODE_MODULE_VERSION is for
Current comment described what to do with it when the ABI changes, but
implied that Node.js would load modules with newer ABI numbers, which it
will not.
PR-URL: https://github.com/nodejs/node/pull/10414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Diffstat (limited to 'src/node_version.h')
| -rw-r--r-- | src/node_version.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/node_version.h b/src/node_version.h index 61b98b1d50..daefafa8eb 100644 --- a/src/node_version.h +++ b/src/node_version.h @@ -44,6 +44,9 @@ (minor) == NODE_MINOR_VERSION && (patch) <= NODE_PATCH_VERSION)) /** + * Node.js will refuse to load modules that weren't compiled against its own + * module ABI number, exposed as the process.versions.modules property. + * * When this version number is changed, node.js will refuse * to load older modules. This should be done whenever * an API is broken in the C++ side, including in v8 or |