diff options
author | Timothy Gu <timothygu99@gmail.com> | 2018-06-22 01:25:12 -0400 |
---|---|---|
committer | Timothy Gu <timothygu99@gmail.com> | 2018-06-25 23:15:35 -0400 |
commit | 65f617314d1ea2df8b9e16fb7e7078b5913c749c (patch) | |
tree | 719a8cf6099c336eddf75af226ca1bfbd0b73965 /src/node_url.cc | |
parent | cd8adfaf98613fb0ae4ba71018a236906f67f286 (diff) | |
download | android-node-v8-65f617314d1ea2df8b9e16fb7e7078b5913c749c.tar.gz android-node-v8-65f617314d1ea2df8b9e16fb7e7078b5913c749c.tar.bz2 android-node-v8-65f617314d1ea2df8b9e16fb7e7078b5913c749c.zip |
src: start annotating native code side effect
PR-URL: https://github.com/nodejs/node/pull/21458
Refs: https://github.com/nodejs/node/issues/20977
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_url.cc')
-rw-r--r-- | src/node_url.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/node_url.cc b/src/node_url.cc index 82c093d516..1cdb179ed2 100644 --- a/src/node_url.cc +++ b/src/node_url.cc @@ -2334,10 +2334,10 @@ static void Initialize(Local<Object> target, void* priv) { Environment* env = Environment::GetCurrent(context); env->SetMethod(target, "parse", Parse); - env->SetMethod(target, "encodeAuth", EncodeAuthSet); - env->SetMethod(target, "toUSVString", ToUSVString); - env->SetMethod(target, "domainToASCII", DomainToASCII); - env->SetMethod(target, "domainToUnicode", DomainToUnicode); + env->SetMethodNoSideEffect(target, "encodeAuth", EncodeAuthSet); + env->SetMethodNoSideEffect(target, "toUSVString", ToUSVString); + env->SetMethodNoSideEffect(target, "domainToASCII", DomainToASCII); + env->SetMethodNoSideEffect(target, "domainToUnicode", DomainToUnicode); env->SetMethod(target, "setURLConstructor", SetURLConstructor); #define XX(name, _) NODE_DEFINE_CONSTANT(target, name); |