diff options
| author | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2019-02-07 12:11:01 -0800 |
|---|---|---|
| committer | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2019-02-11 15:53:14 -0800 |
| commit | 6edf88284b2ef522d2f073e66fa32e9cbe6fafd2 (patch) | |
| tree | 65175e0e1bd38036a2c107861aa9adb6a13d9fba /src/node_report.h | |
| parent | 0aa74443d8bdea3c3840dbc3d4bd700b05ca7a4c (diff) | |
| download | android-node-v8-6edf88284b2ef522d2f073e66fa32e9cbe6fafd2.tar.gz android-node-v8-6edf88284b2ef522d2f073e66fa32e9cbe6fafd2.tar.bz2 android-node-v8-6edf88284b2ef522d2f073e66fa32e9cbe6fafd2.zip | |
n-api: finalize during second-pass callback
Calling into the engine from a weak callback is unsafe, however, the
engine offers a way to attach a second-pass weak callback which gets
called when it is safe to call into JavaScript. This moves the point
at which the N-API finalize callback gets called to this latter point.
Fixes: https://github.com/nodejs/node/issues/25927
PR-URL: https://github.com/nodejs/node/pull/25992
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'src/node_report.h')
0 files changed, 0 insertions, 0 deletions