diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-01-23 00:59:25 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-01-27 16:20:27 +0100 |
| commit | bb774b1554ed7ad7e7b6d588ef5002382afb8183 (patch) | |
| tree | bae63ca1e40f5828d16bf3d3e44dd684b272146c /src/node_report.cc | |
| parent | bafd80883ce2b7ac8f92f31119243af1473269f3 (diff) | |
| download | android-node-v8-bb774b1554ed7ad7e7b6d588ef5002382afb8183.tar.gz android-node-v8-bb774b1554ed7ad7e7b6d588ef5002382afb8183.tar.bz2 android-node-v8-bb774b1554ed7ad7e7b6d588ef5002382afb8183.zip | |
report: do not use `uv_default_loop()` as fallback
Not seeing an associated `Environment` is a rare condition anyway,
but using `uv_default_loop()` as a fallback is not thread-safe.
PR-URL: https://github.com/nodejs/node/pull/25652
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Diffstat (limited to 'src/node_report.cc')
| -rw-r--r-- | src/node_report.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/node_report.cc b/src/node_report.cc index db269903e0..0978d32d90 100644 --- a/src/node_report.cc +++ b/src/node_report.cc @@ -307,8 +307,6 @@ static void WriteNodeReport(Isolate* isolate, writer.json_arraystart("libuv"); if (env != nullptr) uv_walk(env->event_loop(), WalkHandle, static_cast<void*>(&writer)); - else - uv_walk(uv_default_loop(), WalkHandle, static_cast<void*>(&writer)); writer.json_arrayend(); |